Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding integration test for beat Metricbeat module, xpack code path #15967

Merged
merged 4 commits into from
Mar 4, 2020
Merged

Adding integration test for beat Metricbeat module, xpack code path #15967

merged 4 commits into from
Mar 4, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jan 30, 2020 •
edited
Loading

What does this PR do?

This PR:

  • adds an integration test for the Metricbeat beat module when xpack.enabled: true is set in the module configuration, and
  • updates the test beat's version to the latest released one.

Why is it important?

The code path in the beat module when xpack.enabled was set to true was previously not being exercised by integration tests. Moreover, it's a critical code path as it powers the Stack Monitoring feature.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@ycombinator ycombinator added Metricbeat Metricbeat module needs_backport PR is waiting to be backported to other branches. Feature:Stack Monitoring Team:Integrations Label for the Integrations team v7.7.0 v8.0.0 labels Jan 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@ycombinator ycombinator marked this pull request as ready for review January 30, 2020 20:51
@ycombinator ycombinator requested a review from a team as a code owner January 30, 2020 20:51
@ycombinator
Copy link
Contributor Author

jenkins, test this

1 similar comment
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator requested a review from a team February 5, 2020 01:07
@ycombinator ycombinator force-pushed the mb-bt-xp-int-test branch 2 times, most recently from 20c227b to 24547fb Compare February 10, 2020 13:03
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator force-pushed the mb-bt-xp-int-test branch 2 times, most recently from b590baf to 8ce9b92 Compare March 3, 2020 18:43
@ycombinator
Copy link
Contributor Author

CI failures are unrelated and also seen on master. Merging.

@ycombinator ycombinator merged commit 1fc1cb9 into elastic:master Mar 4, 2020
@ycombinator ycombinator mentioned this pull request Mar 4, 2020
Merged
@ycombinator ycombinator deleted the mb-bt-xp-int-test branch March 4, 2020 02:13
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Mar 4, 2020
ycombinator added a commit that referenced this pull request Mar 6, 2020
@ycombinator
Adding integration test for beat Metricbeat module, xpack code path (#…
57ed05a 
…15967) (#16783)

* Adding integration test for beat Metricbeat module, xpack code path

* Update test Beat's version to latest

* Set cluster UUID in test beat config and look for it in test

* Replace assert.* with require.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
Feature:Stack Monitoring Metricbeat Metricbeat module Team:Integrations Label for the Integrations team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @ChrsMark @andresrc