Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Use nested objects so fleet can handle metadata correctly #18234

Merged
merged 2 commits into from
May 5, 2020
Merged

[Elastic-Agent] Use nested objects so fleet can handle metadata correctly #18234

merged 2 commits into from
May 5, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 5, 2020 •
edited
Loading

What does this PR do?

moves agent metadata to elastic object, if not nested object is constructed in a weird way on fleet side

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
@michalpristas michalpristas removed the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2020
@michalpristas michalpristas added the needs_backport PR is waiting to be backported to other branches. label May 5, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas merged commit 18d34e5 into elastic:master May 5, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 5, 2020
@michalpristas
[Elastic-Agent] Use nested objects so fleet can handle metadata corre…
536441b 
…ctly (elastic#18234)

* use subobject so kibana can handle correctly

* changelog
@michalpristas michalpristas mentioned this pull request May 5, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request May 5, 2020
@michalpristas
[Elastic-Agent] Use nested objects so fleet can handle metadata corre…
9e25260 
…ctly (#18234) (#18241)

* use subobject so kibana can handle correctly

* changelog
@ruflin ruflin mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
enhancement Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ruflin