[Fleet] Fix display of local_metadata #65260
Conversation
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
| @@ -505,7 +511,7 @@ export const AgentListPage: React.FunctionComponent<{}> = () => { | |||
| loading={isLoading && agentsRequest.isInitialRequest} | |||
| hasActions={true} | |||
| noItemsMessage={ | |||
| isLoading ? ( | |||
| isLoading && agentsRequest.isInitialRequest ? ( | |||
There was a problem hiding this comment.
I added this to avoid a blink effect, every 30 seconds.
| @@ -30,7 +30,11 @@ export const AgentDetailsContent: React.FunctionComponent<{ | |||
| title: i18n.translate('xpack.ingestManager.agentDetails.hostNameLabel', { | |||
| defaultMessage: 'Host name', | |||
| }), | |||
| description: agent.local_metadata['host.hostname'], | |||
| description: | |||
There was a problem hiding this comment.
LOL i was expecting some black magic
|
elastic/beats#18234 got merged. Did you test this with an older or newer agent? I tried this on my end and got mixed results :-) |
|
I did not tested it with this change, going to test it, I probably need to update the version too |
|
I pushed a change that is working with the latest agent |
|
This is with agent built from beats master 3df5db4f6360a88930d5569451f10e57caa35d59 , on It also fixes the React error on the agents list for me. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@paul-tavares Maybe it could interest you not sure how you use agent metadata in endpoint but the host is now, ECS compliant and under |
Summary
Resolve #65238
fix display of
local_metadata, I added some type guard also to be sure to not break the page if we have invalid metadata.With the latest agent:
