-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move service config under stackdriver.metrics and simplify metric_types #18691
Conversation
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, it seems to simplify configurations. I think it should be marked as breaking change.
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
…es (elastic#18691) * Move service name config under stackdriver.metrics and simplify metric_types * change config stackdriver.metrics to metrics
What does this PR do?
This PR is to move service config parameter from under
stackdriver
to understackdriver.metrics
. Service name used to only be used for checking metadata. Now it's also been used to construct the fullmetric_type
string to make google cloud API calllist.timeseries
.For example, if
service=compute
and metric_type is given in config asinstance/cpu/usage_time
, then the full metric.type will becompute/googleapi.com/instance/cpu/usage_time
.This PR also removed the
stackdriver
config layer. Now instead ofstackdriver.metrics
, configs are directly undermetrics
.Before:
After:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
./metricbeat modules enable googlecloud
modules.d/googlecloud.yml
to below:googlecloud.stackdriver.instance.cpu.reserved_cores.value
,googlecloud.stackdriver.instance.cpu.usage_time.value
,googlecloud.stackdriver.instance.cpu.utilization.value
andgooglecloud.stackdriver.instance.uptime.value
should be collected.