Cherry-pick #18691 to 7.x: Move service config under stackdriver.metrics and simplify metric_types #18981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ChrsMark
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18691 to 7.x branch. Original message:
What does this PR do?
This PR is to move service config parameter from under
stackdriverto understackdriver.metrics. Service name used to only be used for checking metadata. Now it's also been used to construct the fullmetric_typestring to make google cloud API calllist.timeseries.For example, if
service=computeand metric_type is given in config asinstance/cpu/usage_time, then the full metric.type will becompute/googleapi.com/instance/cpu/usage_time.This PR also removed the
stackdriverconfig layer. Now instead ofstackdriver.metrics, configs are directly undermetrics.Before:
After:
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
./metricbeat modules enable googlecloudmodules.d/googlecloud.ymlto below:googlecloud.stackdriver.instance.cpu.reserved_cores.value,googlecloud.stackdriver.instance.cpu.usage_time.value,googlecloud.stackdriver.instance.cpu.utilization.valueandgooglecloud.stackdriver.instance.uptime.valueshould be collected.