Fix parsing timestamp in test #19796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
kvch
approved these changes
Jul 13, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 13, 2020
* upstream/master: Fix parsing timestamp in Filebeat registry tests (elastic#19796) Add text & flattened fields in aws cloudtrail fileset (elastic#19121)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 13, 2020
* upstream/master: [CI] support windows-2012 (elastic#19773) Do not update go.mod during packaging and testing (elastic#19823) Fix typo in ILM warning message (elastic#19819) [Winlogbeat] Remove beta tag from Powershell and Security modules (elastic#19817) feat: move the multibranch pipeline job to the beats repo (elastic#19698) Fix parsing timestamp in Filebeat registry tests (elastic#19796) Add text & flattened fields in aws cloudtrail fileset (elastic#19121)
1 task
urso
added
v7.9.0
and removed
needs_backport
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jul 13, 2020
(cherry picked from commit 0027486)
urso
pushed a commit
that referenced
this pull request
Jul 14, 2020
(cherry picked from commit 0027486)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix parsing the registry file timestamp in system tests.
Why is it important?
Some system tests can have multiple entries for the same path (e.g. after rename or copy). To compensate for this the tests sort entries by timestamp when looking up a path.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs