Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update go.mod during packaging and testing #19823

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jul 13, 2020

What does this PR do?

This PR adds -mod=readonly to Golang commands.

Why is it important?

Now that vendor is no longer part of the repo, Go might accidentally update dependencies during integration testing, updating generated assets and packaging. To avoid it, I have added -mod=readonly to these commands.

This possibly affects the apm-server repo as well. So CC @elastic/apm-server

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

CC @v1v I believe this PR fixes all our problems with Golang updating reps. But as a safety measure, we should adjust the CIs as well.

@kvch kvch requested review from urso, axw and v1v July 13, 2020 08:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@v1v
Copy link
Member

v1v commented Jul 13, 2020

@kvch , awesome, should I raise a contribute to this PR for the CI changes or in another one?

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

For the CI part, I did inject the environment variable but only in the linting stage:

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 13, 2020

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-13T09:43:38.117+0000

  • Duration: 123 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 6716
Skipped 1413
Total 8129

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 1 min 27 sec

    • Start Time: 2020-07-13T11:17:50.654+0000

    • log

  • Name: Make -C filebeat testsuite

    • Description: make -C filebeat testsuite

    • Duration: 8 min 45 sec

    • Start Time: 2020-07-13T10:11:14.905+0000

    • log

  • Name: Mage update build test

    • Description: mage update build test

    • Duration: 5 min 15 sec

    • Start Time: 2020-07-13T10:11:06.503+0000

    • log

  • Name: Notifies GitHub of the status of a Pull Request

  • Name: Make -C auditbeat testsuite

    • Description: make -C auditbeat testsuite

    • Duration: 8 min 6 sec

    • Start Time: 2020-07-13T10:11:05.976+0000

    • log

  • Name: Mage update build test

    • Description: mage update build test

    • Duration: 4 min 45 sec

    • Start Time: 2020-07-13T10:11:07.673+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 1 min 27 sec

    • Start Time: 2020-07-13T11:24:59.786+0000

    • log

  • Name: Make -C libbeat testsuite

    • Description: make -C libbeat testsuite

    • Duration: 14 min 1 sec

    • Start Time: 2020-07-13T10:10:58.656+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-13T10:25:05.376+0000

    • log

  • Name: Make -C x-pack/libbeat testsuite

    • Description: make -C x-pack/libbeat testsuite

    • Duration: 6 min 17 sec

    • Start Time: 2020-07-13T10:11:01.123+0000

    • log

  • Name: Mage goIntegTest

    • Description: mage goIntegTest

    • Duration: 5 min 50 sec

    • Start Time: 2020-07-13T10:11:14.661+0000

    • log

  • Name: Mage pythonIntegTest

    • Description: mage pythonIntegTest

    • Duration: 3 min 30 sec

    • Start Time: 2020-07-13T10:11:15.668+0000

    • log

  • Name: Mage build test

    • Description: mage build test

    • Duration: 8 min 41 sec

    • Start Time: 2020-07-13T10:45:16.600+0000

    • log

  • Name: Make -C packetbeat testsuite

    • Description: make -C packetbeat testsuite

    • Duration: 7 min 38 sec

    • Start Time: 2020-07-13T10:11:05.066+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=auditbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f auditbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=filebeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f filebeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=heartbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f heartbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=libbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f libbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=metricbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f metricbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=packetbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f packetbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f winlogbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:36.231Z] + for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat
[2020-07-13T11:40:36.231Z] + FILE=journalbeat/build/coverage/full.cov
[2020-07-13T11:40:36.231Z] + '[' -f journalbeat/build/coverage/full.cov ']'
[2020-07-13T11:40:37.651Z] Post stage
[2020-07-13T11:40:37.671Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats
[2020-07-13T11:40:38.563Z] Starting "default"...
[2020-07-13T11:40:38.564Z] Machine "default" is already running.
[2020-07-13T11:42:19.550Z] Error checking TLS connection: ssh command error:
[2020-07-13T11:42:19.550Z] command : ip addr show
[2020-07-13T11:42:19.550Z] err     : exit status 255
[2020-07-13T11:42:19.550Z] output  : 
[2020-07-13T11:42:19.550Z] Client: Docker Engine - Community
[2020-07-13T11:42:19.550Z]  Version:           19.03.1
[2020-07-13T11:42:19.550Z]  API version:       1.40
[2020-07-13T11:42:19.550Z]  Go version:        go1.12.5
[2020-07-13T11:42:19.550Z]  Git commit:        74b1e89
[2020-07-13T11:42:19.550Z]  Built:             Thu Jul 25 21:18:17 2019
[2020-07-13T11:42:19.550Z]  OS/Arch:           darwin/amd64
[2020-07-13T11:42:19.550Z]  Experimental:      false
[2020-07-13T11:42:19.550Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-07-13T11:42:19.550Z] It requires Docker daemon to be installed and running
[2020-07-13T11:45:16.047Z] Cancelling nested steps due to timeout
[2020-07-13T11:45:16.522Z] Stage "Functionbeat Windows" skipped due to earlier failure(s)
[2020-07-13T11:45:16.545Z] Stage "Generators Beat Mac OS X" skipped due to earlier failure(s)
[2020-07-13T11:45:17.852Z] Failed in branch Functionbeat
[2020-07-13T11:45:17.875Z] Failed in branch Generators
[2020-07-13T11:45:33.391Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats
[2020-07-13T11:45:34.096Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-13T11:45:34.558Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Lint
[2020-07-13T11:45:35.772Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-13T11:45:36.723Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-13T11:45:37.528Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-13T11:45:38.268Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-13T11:45:38.886Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-13T11:45:39.276Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-13T11:45:39.826Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-07-13T11:45:40.557Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-13T11:45:41.395Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-13T11:45:42.443Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-13T11:45:43.502Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-07-13T11:45:44.795Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-13T11:45:46.108Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-13T11:45:47.384Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-13T11:45:48.536Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-13T11:45:49.619Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Packetbeat-oss
[2020-07-13T11:45:50.649Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-13T11:45:51.639Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-oss
[2020-07-13T11:45:52.625Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-13T11:45:54.690Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-13T11:45:55.650Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-13T11:45:56.619Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-13T11:45:57.640Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-13T11:45:58.455Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-13T11:45:59.055Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-13T11:45:59.883Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-13T11:46:00.703Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Libbeat-oss
[2020-07-13T11:46:01.908Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-13T11:46:02.777Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-13T11:46:03.811Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-13T11:46:04.820Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-13T11:46:06.010Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-13T11:46:06.921Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-13T11:46:08.248Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-13T11:46:09.691Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-13T11:46:10.702Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-13T11:46:12.145Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19823/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-13T11:46:13.781Z] + cat
[2020-07-13T11:46:13.793Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-13T11:46:13.793Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-13T11:46:16.048Z] Body did not finish within grace period; terminating with extreme prejudice
[2020-07-13T11:46:16.553Z] ERROR: runbld post build action failed.
[2020-07-13T11:46:16.553Z] Timeout has been exceeded
[2020-07-13T11:46:19.261Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats_PR-19823
[2020-07-13T11:46:20.111Z] [INFO] getVaultSecret: Getting secrets
[2020-07-13T11:46:20.792Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-13T11:46:27.512Z] + chmod 755 generate-build-data.sh
[2020-07-13T11:46:27.512Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19823/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19823/runs/1 ABORTED 7367856
[2020-07-13T11:46:27.512Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19823/runs/1/steps/?limit=10000 -o steps-info.json
[2020-07-13T11:46:31.681Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19823/runs/1/tests/?status=FAILED -o tests-errors.json

@kvch kvch merged commit f91c96f into elastic:master Jul 13, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Jul 13, 2020
kvch added a commit to kvch/beats that referenced this pull request Jul 13, 2020
@kvch kvch added the v7.9.0 label Jul 13, 2020
kvch added a commit that referenced this pull request Jul 13, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 13, 2020
* upstream/master:
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  Fix typo in ILM warning message (elastic#19819)
  [Winlogbeat] Remove beta tag from Powershell and Security modules (elastic#19817)
  feat: move the multibranch pipeline job to the beats repo (elastic#19698)
  Fix parsing timestamp in Filebeat registry tests (elastic#19796)
  Add text & flattened fields in aws cloudtrail fileset (elastic#19121)
v1v added a commit to v1v/beats that referenced this pull request Jul 14, 2020
* upstream/master: (25 commits)
  [Elastic Agent] Send checkin payload to Fleet (elastic#19857)
  [Ingest Manager] Fixed tests across agent elastic#19877
  [Ingest Manager] Fix serialization test  elastic#19876
  Fix service start type mapping in windows/service metricset (elastic#19551)
  ci: Change comment trigger detection method (elastic#19827)
  Add 21 autogenerated filesets from rsa2elk devices (elastic#19713)
  [Ingest Manager] Agent config cleanup (elastic#19848)
  libbeat/publisher/pipeline: fix data races (elastic#19821)
  Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697)
  [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861)
  Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159)
  Add azure billing metricset (elastic#19207)
  Add support for appinsights in the metricbeat azure module (elastic#18940)
  Add MySQL query metricset with lightweight module and SQL helper (elastic#18955)
  [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587)
  Do not use vendor during integration tests (elastic#19839)
  LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683)
  [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761)
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants