Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service start type mapping in windows/service metricset #19551

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Fix service start type mapping in windows/service metricset #19551

merged 5 commits into from
Jul 14, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Jul 1, 2020

What does this PR do?

Fixes start type service mapping.

Why is it important?

Service start type property returned an empty string

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@narph narph changed the title Fix service start type mapping Fix service start type mapping in windows/service metricset Jul 1, 2020
@narph narph self-assigned this Jul 1, 2020
@narph narph added [zube]: In Review Team:Integrations Label for the Integrations team labels Jul 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2020
@narph narph added the needs_backport PR is waiting to be backported to other branches. label Jul 1, 2020
@zube zube bot added [zube]: Inbox [zube]: In Review and removed [zube]: In Review needs_backport PR is waiting to be backported to other branches. [zube]: Inbox labels Jul 1, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 1, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19551 updated]

  • Start Time: 2020-07-14T07:49:52.925+0000

  • Duration: 76 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 3038
Skipped 687
Total 3725

Steps errors

Expand to view the steps failures

  • Name: Install Go 1.14.4

    • Description: .ci/scripts/install-go.sh

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-14T08:13:55.913+0000

    • log

  • Name: Install docker-compose 1.21.0

    • Description: .ci/scripts/install-docker-compose.sh

    • Duration: 1 min 32 sec

    • Start Time: 2020-07-14T08:15:04.612+0000

    • log

@narph narph added the needs_backport PR is waiting to be backported to other branches. label Jul 7, 2020
@narph narph merged commit 194be7f into elastic:master Jul 14, 2020
@narph narph deleted the fix-service branch July 14, 2020 09:44
narph added a commit to narph/beats that referenced this pull request Jul 14, 2020
@narph
Fix service start type mapping in windows/service metricset (elastic#…
3e160e0 
…19551)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
@narph narph mentioned this pull request Jul 14, 2020
Merged
6 tasks
narph added a commit to narph/beats that referenced this pull request Jul 14, 2020
@narph
Fix service start type mapping in windows/service metricset (elastic#…
72c4134 
…19551)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
@narph narph mentioned this pull request Jul 14, 2020
Merged
6 tasks
v1v added a commit to v1v/beats that referenced this pull request Jul 14, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
de92936 
* upstream/master: (25 commits)
  [Elastic Agent] Send checkin payload to Fleet (elastic#19857)
  [Ingest Manager] Fixed tests across agent elastic#19877
  [Ingest Manager] Fix serialization test  elastic#19876
  Fix service start type mapping in windows/service metricset (elastic#19551)
  ci: Change comment trigger detection method (elastic#19827)
  Add 21 autogenerated filesets from rsa2elk devices (elastic#19713)
  [Ingest Manager] Agent config cleanup (elastic#19848)
  libbeat/publisher/pipeline: fix data races (elastic#19821)
  Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697)
  [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861)
  Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159)
  Add azure billing metricset (elastic#19207)
  Add support for appinsights in the metricbeat azure module (elastic#18940)
  Add MySQL query metricset with lightweight module and SQL helper (elastic#18955)
  [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587)
  Do not use vendor during integration tests (elastic#19839)
  LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683)
  [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761)
  [CI] support windows-2012 (elastic#19773)
  Do not update go.mod during packaging and testing (elastic#19823)
  ...
narph added a commit that referenced this pull request Jul 15, 2020
@narph
Fix service start type mapping in windows/service metricset (#19551) (#…
9b8be5e 
…19879)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
narph added a commit that referenced this pull request Jul 15, 2020
@narph
Fix service start type mapping in windows/service metricset (#19551) (#…
0846b6c 
…19878)

* fit service start type

* test

* changelog

(cherry picked from commit 194be7f)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@narph @melchiormoulin
Fix service start type mapping in windows/service metricset (elastic#…
b80a992 
…19551)

* fit service start type

* test

* changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Fix service start type mapping in windows/service metricset (elastic#…
32b2b72 
…19551) (elastic#19879)

* fit service start type

* test

* changelog

(cherry picked from commit 262b6f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@narph narph

Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @exekias @andresrc