-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azure billing metricset #19207
Add azure billing metricset #19207
Conversation
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
vendor work run fix change fix fix dependencies work fix
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good! Just several small comments.
@@ -97,6 +97,11 @@ so the `period` for `container_service` metricset should be `300s` or multiples | |||
This metricset will collect relevant metrics from specified database accounts, these metrics will have a timegrain every 5 minutes, | |||
so the `period` for `database_account` metricset should be `300s` or multiples of `300s`. | |||
|
|||
[float] | |||
=== `billing` | |||
This metricset will collect relevant usage data and forecast information from the specific subscription, these metrics will have a timegrain every 24 hours, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This metricset will collect relevant usage data and forecast information from the specific subscription, these metrics will have a timegrain every 24 hours, | |
This metricset will collect relevant usage data and forecast information from a specific subscription. These metrics will have a timegrain every 24 hours, |
Lint failure should be fixed in master now. If you rebase this PR, hopefully CI will turn green 😄 |
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com> (cherry picked from commit e69eb97)
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com> (cherry picked from commit e69eb97)
* upstream/master: (25 commits) [Elastic Agent] Send checkin payload to Fleet (elastic#19857) [Ingest Manager] Fixed tests across agent elastic#19877 [Ingest Manager] Fix serialization test elastic#19876 Fix service start type mapping in windows/service metricset (elastic#19551) ci: Change comment trigger detection method (elastic#19827) Add 21 autogenerated filesets from rsa2elk devices (elastic#19713) [Ingest Manager] Agent config cleanup (elastic#19848) libbeat/publisher/pipeline: fix data races (elastic#19821) Update monitoring-internal-collection.asciidoc (elastic#19422) (elastic#19697) [Elastic Agent] Trust exchange endpoint must bind to 127.0.0.1 (elastic#19861) Specify an ECS version in Auditbeat/Packetbeat/Winlogbeat (elastic#19159) Add azure billing metricset (elastic#19207) Add support for appinsights in the metricbeat azure module (elastic#18940) Add MySQL query metricset with lightweight module and SQL helper (elastic#18955) [Ingest Manager] Refuse invalid stream values in configuration (elastic#19587) Do not use vendor during integration tests (elastic#19839) LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP (elastic#18683) [Elastic Agent] Remove support for "logs" and only support logfile (elastic#19761) [CI] support windows-2012 (elastic#19773) Do not update go.mod during packaging and testing (elastic#19823) ...
* work on metricset vendor work run fix change fix fix dependencies work fix * remove vendor * remove unused * work on the billing * make notice * work on fields * build dashboards * make notice * review * make sure * is set to auto in gitattributes * test * update CLRF to LF * update CLRF to LF * notice * notice * Fix notice * update visualization Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> Co-authored-by: Carlos Pérez-Aradros Herce <exekias@gmail.com>
What does this PR do?
Adds usage and costs metrics from azure subscriptions
Why is it important?
Shows relevant charges and forecast information
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Enable billing metricset in the azure module
Related issues
Screenshots