Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache, rows stats and connection errors data to status metricset in MySQL module #19844

Merged
merged 9 commits into from
Jul 14, 2020
Merged

Add cache, rows stats and connection errors data to status metricset in MySQL module #19844

merged 9 commits into from
Jul 14, 2020

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jul 13, 2020 •
edited
Loading

What does this PR do?

Adds cache, connection errors and rows stats metrics to the status Metricset in MySQL module as requested in #16955

I'll have to confirm metrics in this PR by the team before attaching any dashboard to avoid modifying it multiple times.

Why is it important?

The enhancement is a step forward to improve the MySQL module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@sayden sayden added enhancement Team:Services (Deprecated) Label for the former Integrations-Services team labels Jul 13, 2020
@sayden sayden self-assigned this Jul 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 13, 2020
@sayden sayden changed the title Add cache and connection errors data to status metricset in MySQL module Add cache, rows stats and connection errors data to status metricset in MySQL module Jul 13, 2020
@sayden sayden mentioned this pull request Jul 13, 2020
Open
@sayden sayden added the Metricbeat Metricbeat label Jul 14, 2020
ChrsMark
ChrsMark approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Left some minors.

metricbeat/module/mysql/status/_meta/fields.yml Show resolved Hide resolved
metricbeat/module/mysql/status/_meta/fields.yml Show resolved Hide resolved
metricbeat/module/mysql/status/data.go Show resolved Hide resolved
@sayden
Copy link
Contributor Author

sayden commented Jul 14, 2020

CI failures are related, checking

@sayden sayden merged commit 91aca53 into elastic:master Jul 14, 2020
sayden added a commit to sayden/beats that referenced this pull request Jul 14, 2020
@sayden
Add cache, rows stats and connection errors data to status metricset …
aa6b4f1 
…in MySQL module (elastic#19844)

(cherry picked from commit 91aca53)
@sayden sayden mentioned this pull request Jul 14, 2020
Merged
6 tasks
@sayden sayden added the v7.9.0 label Jul 14, 2020
sayden added a commit that referenced this pull request Jul 14, 2020
@sayden
Add cache, rows stats and connection errors data to status metricset …
b9b1a6a 
…in MySQL module (#19844) (#19903)

(cherry picked from commit 91aca53)
This was referenced Jul 14, 2020
Merged
Merged
Merged
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@sayden @melchiormoulin
Add cache, rows stats and connection errors data to status metricset …
2f6e3ea 
…in MySQL module (elastic#19844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@sayden sayden

Labels
enhancement Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Revisit MySQL module
4 participants
@sayden @elasticmachine @ChrsMark @andresrc