Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Update MySQL dashboard #19913

Merged
merged 6 commits into from
Jul 17, 2020
Merged

[Metricbeat] Update MySQL dashboard #19913

merged 6 commits into from
Jul 17, 2020

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jul 14, 2020

What does this PR do?

Update MySQL dashboard with the metrics merged in #19844

Related issues

Screenshots

image

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
@sayden sayden self-assigned this Jul 14, 2020
@sayden sayden changed the title Atomic commit [Metricbeat] Update MySQL dashboard Jul 14, 2020
@sayden sayden added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jul 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2020
kaiyan-sheng
kaiyan-sheng reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about update the dashboard screenshot in doc?

kaiyan-sheng
kaiyan-sheng approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait till ci 🟢

@kaiyan-sheng
Copy link
Contributor 

>> Dashboard format - module/mysql/_meta/kibana/7/dashboard/Metricbeat-mysql-overview.json:
   expected title with format 'Some title [Metricbeat Module]', found 'Open Tables Cache [MySQL Metricbeat] ECS': expected: 'Metricbeat', found: 'MySQL'
   expected title with format 'Some title [Metricbeat Module]', found 'Connection Errors [MySQL Metricbeat] ECS': expected: 'Metricbeat', found: 'MySQL'
   expected title with format 'Some title [Metricbeat Module]', found 'Commands Operations [MySQL Metricbeat] ECS': expected: 'Metricbeat', found: 'MySQL'
   expected title with format 'Some title [Metricbeat Module]', found 'SSL Cache [MySQL Metricbeat] ECS': expected: 'Metricbeat', found: 'MySQL'

So it should be [Metricbeat MySQL] instead of [MySQL Metricbeat]?

@sayden
Copy link
Contributor Author

sayden commented Jul 15, 2020

Ok, I have switched positions of MySQL and Metricbeat 🤓

@sayden
Copy link
Contributor Author

sayden commented Jul 15, 2020

CI Error is related

@sayden sayden merged commit c915bf7 into elastic:master Jul 17, 2020
@sayden sayden mentioned this pull request Jul 17, 2020
Merged
sayden added a commit to sayden/beats that referenced this pull request Jul 17, 2020
@sayden
[Metricbeat] Update MySQL dashboard (elastic#19913)
a10534f 
(cherry picked from commit c915bf7)
@sayden sayden added the v7.9.0 label Jul 17, 2020
sayden added a commit to sayden/beats that referenced this pull request Jul 17, 2020
@sayden
[Metricbeat] Update MySQL dashboard (elastic#19913)
0c61883 
(cherry picked from commit c915bf7)
@sayden sayden mentioned this pull request Jul 17, 2020
Merged
sayden added a commit that referenced this pull request Jul 17, 2020
@sayden
[Metricbeat] Update MySQL dashboard (#19913) (#20024)
deb738a 
(cherry picked from commit c915bf7)
sayden added a commit that referenced this pull request Jul 17, 2020
@sayden
[Metricbeat] Update MySQL dashboard (#19913) (#20025)
1d71d90 
(cherry picked from commit c915bf7)
v1v added a commit to v1v/beats that referenced this pull request Jul 20, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/fix-warni…
cf807c2 
…ngs-archive

* upstream/master: (274 commits)
  Test export commands in all Beats (elastic#20016)
  [Ingest Manager] Allow using drop path for agent build (elastic#20019)
  [DOCS] Remove include for deleted file in monitoring docs (elastic#20038)
  Removing xpack.monitoring.* settings (elastic#18608)
  [Heartbeat] Add service_name option for APM integration (elastic#19932)
  [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026)
  Stricter stalebot configuration for PRs (elastic#20004)
  [ci] Favor direct mage invocation on CI (elastic#19960)
  Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973)
  [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972)
  [Metricbeat] Update MySQL dashboard (elastic#19913)
  Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945)
  [CI] fix MODULE variable cornercases (elastic#19985)
  Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998)
  add 7.9 to .backportrc.json (elastic#19952)
  Update internal links to external (elastic#19947)
  Remove Dynamic Script Compilations warning in Cisco module (elastic#19840)
  [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959)
  [Ingest Manager] Do not compare err with custom type (elastic#19980)
  Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675)
  ...
v1v added a commit to v1v/beats that referenced this pull request Jul 20, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/ci-read-o…
a6c5555 
…nly-mod

* upstream/master: (75 commits)
  Test export commands in all Beats (elastic#20016)
  [Ingest Manager] Allow using drop path for agent build (elastic#20019)
  [DOCS] Remove include for deleted file in monitoring docs (elastic#20038)
  Removing xpack.monitoring.* settings (elastic#18608)
  [Heartbeat] Add service_name option for APM integration (elastic#19932)
  [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026)
  Stricter stalebot configuration for PRs (elastic#20004)
  [ci] Favor direct mage invocation on CI (elastic#19960)
  Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973)
  [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972)
  [Metricbeat] Update MySQL dashboard (elastic#19913)
  Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945)
  [CI] fix MODULE variable cornercases (elastic#19985)
  Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998)
  add 7.9 to .backportrc.json (elastic#19952)
  Update internal links to external (elastic#19947)
  Remove Dynamic Script Compilations warning in Cisco module (elastic#19840)
  [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959)
  [Ingest Manager] Do not compare err with custom type (elastic#19980)
  Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@sayden @melchiormoulin
[Metricbeat] Update MySQL dashboard (elastic#19913)
3354d57
@zube zube bot removed the [zube]: Done label Oct 16, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@sayden
[Metricbeat] Update MySQL dashboard (elastic#19913) (elastic#20025)
8e26c96 
(cherry picked from commit fc4bcd6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresrc andresrc andresrc left review comments

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@sayden sayden

Labels
enhancement Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayden @elasticmachine @kaiyan-sheng @andresrc