-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20540 to 7.x: Fix Winlogbeat export index-pattern with migration.6_to_7.enabled #20574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 12, 2020
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 12, 2020
adriansr
force-pushed
the
backport_20540_7.x
branch
from
August 12, 2020 14:58
420eb13
to
751728e
Compare
Collaborator
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
This adds 4 new integration tests to all Beats that test export commands: > beatname export ilm-policy > beatname export template > beatname export index-pattern > beatname export config
* Add export tests to x-pack/filebeat Add export sub-command tests to x-pack/filebeat and add an assertion for the size the Kibana index-pattern due to the Kibana API limiting payloads to 1 MiB. * Assert size of index pattern document is less than 1 MiB
…astic#20540) - Test export index-pattern with migration.6_to_7.enabled=true - Always run these tests, not only when integration testing - Remove conflicting Winlogbeat alias
adriansr
force-pushed
the
backport_20540_7.x
branch
from
August 14, 2020 08:19
751728e
to
00a65ac
Compare
leehinman
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Aug 17, 2020
… with migration.6_to_7.enabled (elastic#20574) * Test export commands in all Beats (elastic#20016) This adds 4 new integration tests to all Beats that test export commands: > beatname export ilm-policy > beatname export template > beatname export index-pattern > beatname export config * [Filebeat] Add export tests to x-pack/filebeat (elastic#20156) * Add export tests to x-pack/filebeat Add export sub-command tests to x-pack/filebeat and add an assertion for the size the Kibana index-pattern due to the Kibana API limiting payloads to 1 MiB. * Assert size of index pattern document is less than 1 MiB * Fix Winlogbeat export index-pattern with migration.6_to_7.enabled (elastic#20540) - Test export index-pattern with migration.6_to_7.enabled=true - Always run these tests, not only when integration testing - Remove conflicting Winlogbeat alias * Changelog entry Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 9ec7549)
adriansr
added a commit
that referenced
this pull request
Aug 17, 2020
…igration.6_to_7.enabled (#20628) * Cherry-pick #20540 to 7.x: Fix Winlogbeat export index-pattern with migration.6_to_7.enabled (#20574) * Test export commands in all Beats (#20016) This adds 4 new integration tests to all Beats that test export commands: > beatname export ilm-policy > beatname export template > beatname export index-pattern > beatname export config * [Filebeat] Add export tests to x-pack/filebeat (#20156) * Add export tests to x-pack/filebeat Add export sub-command tests to x-pack/filebeat and add an assertion for the size the Kibana index-pattern due to the Kibana API limiting payloads to 1 MiB. * Assert size of index pattern document is less than 1 MiB * Fix Winlogbeat export index-pattern with migration.6_to_7.enabled (#20540) - Test export index-pattern with migration.6_to_7.enabled=true - Always run these tests, not only when integration testing - Remove conflicting Winlogbeat alias Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 9ec7549)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… with migration.6_to_7.enabled (elastic#20628) * Cherry-pick elastic#20540 to 7.x: Fix Winlogbeat export index-pattern with migration.6_to_7.enabled (elastic#20574) * Test export commands in all Beats (elastic#20016) This adds 4 new integration tests to all Beats that test export commands: > beatname export ilm-policy > beatname export template > beatname export index-pattern > beatname export config * [Filebeat] Add export tests to x-pack/filebeat (elastic#20156) * Add export tests to x-pack/filebeat Add export sub-command tests to x-pack/filebeat and add an assertion for the size the Kibana index-pattern due to the Kibana API limiting payloads to 1 MiB. * Assert size of index pattern document is less than 1 MiB * Fix Winlogbeat export index-pattern with migration.6_to_7.enabled (elastic#20540) - Test export index-pattern with migration.6_to_7.enabled=true - Always run these tests, not only when integration testing - Remove conflicting Winlogbeat alias Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit 66cfa25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20540 #20156 and #20016 to 7.x branch. Original message:
What does this PR do?
Fixes a duplicated field in Winlogbeat's index pattern when
migration.6_to_7.enabled
istrue
.Updates the common system/tests for all Beats to test that the command below works:
Why is it important?
To catch cases where migration aliases cause field duplication or other issues.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues