Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml warnings in python scripts and tests #20606

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Fix yaml warnings in python scripts and tests #20606

merged 1 commit into from
Aug 16, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 14, 2020 •
edited
Loading

What does this PR do?

Fix yaml warnings in python scripts and tests as proposed in https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

Why is it important?

To avoid using deprecated code that may stop working in the future.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@jsoriano jsoriano added review Team:Integrations Label for the Integrations team labels Aug 14, 2020
@jsoriano jsoriano self-assigned this Aug 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 14, 2020
andrewkroh
andrewkroh approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Aug 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20606 opened]

  • Start Time: 2020-08-14T14:30:19.180+0000

  • Duration: 74 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 17976
Skipped 1827
Total 19803

@jsoriano jsoriano merged commit e4baae6 into elastic:master Aug 16, 2020
@jsoriano jsoriano deleted the python-yaml-warnings branch August 16, 2020 15:15
@jsoriano
Copy link
Member Author

To be backported after #20574

jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 18, 2020
@jsoriano
Fix yaml warnings in python scripts and tests (elastic#20606)
e5ca7c7 
(cherry picked from commit e4baae6)
@jsoriano jsoriano mentioned this pull request Aug 18, 2020
Merged
6 tasks
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 18, 2020
jsoriano added a commit that referenced this pull request Aug 18, 2020
@jsoriano
Fix yaml warnings in python scripts and tests (#20606) (#20661)
d0b5dea 
(cherry picked from commit e4baae6)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@jsoriano @melchiormoulin
Fix yaml warnings in python scripts and tests (elastic#20606)
ccdc49b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@kvch kvch kvch approved these changes

Assignees

@jsoriano jsoriano

Labels
review Team:Integrations Label for the Integrations team technical debt v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @elasticmachine @kvch @andrewkroh