Fix python deprecation warnings #20603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
5 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
6 tasks
6 tasks
jsoriano
force-pushed
the
python-deprecation-errors
branch
from
b659ea4
to
d956727
Compare
jsoriano
force-pushed
the
python-deprecation-errors
branch
2 times, most recently
from
083a7f5
to
35353e6
Compare
jsoriano
force-pushed
the
python-deprecation-errors
branch
from
d7ed8be
to
7eb03a7
Compare
|
Pinging @elastic/integrations (Team:Integrations) |
jsoriano
changed the title
cachedout
approved these changes
Sep 7, 2020
botelastic
bot
added
the
Team:Automation
kuisathaverat
approved these changes
Sep 7, 2020
6 tasks
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 7, 2020
Solve python deprecation warnings, and make python tests to fail if deprecated code is added. Changes here: * Add error::DeprecationWarning to pytest's filterwarnings (so tests fail if use deprecated code). * Add pytest.ini to the list of files that trigger all CI builds. * Refactor tests to don't require deprecated assertDictContainsSubset. * Update autopep8 to latest version, and run it once with -a (aggresive). * Solve some other deprecation warnings not solved automatically by autopep8 -a. (cherry picked from commit bed3964)
jsoriano
added a commit
that referenced
this pull request
Sep 9, 2020
Solve python deprecation warnings, and make python tests to fail if deprecated code is added. Changes here: * Add error::DeprecationWarning to pytest's filterwarnings (so tests fail if use deprecated code). * Add pytest.ini to the list of files that trigger all CI builds. * Refactor tests to don't require deprecated assertDictContainsSubset. * Update autopep8 to latest version, and run it once with -a (aggresive). * Solve some other deprecation warnings not solved automatically by autopep8 -a. (cherry picked from commit bed3964)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 2, 2020
v1v
added a commit
that referenced
this pull request
Oct 2, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 2, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 2, 2020
…ne-2.0-arm * upstream/master: (54 commits) [CI] Change x-pack/auditbeat build events (comments, labels) (elastic#21463) [CI] changeset from elastic#20603 was not added to CI2.0 (elastic#21464) Add new log file reader for filestream input (elastic#21450) [CI] Send slack message with build status (elastic#21428) Remove duplicated sources url in dependencies report (elastic#21462) Add implementation of FSWatcher and FSScanner for filestream (elastic#21444) [Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406) Update Filebeat module expected logs files (elastic#21454) Edit SQL module docs and fix broken doc structure (elastic#21233) [Ingest Manager] Send snapshot flag together with metadata (elastic#21285) Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447) [JJBB] Use reference repo for fast checkouts (elastic#21410) Add initial skeleton of filestream input (elastic#21427) Initial spec file for apm-server (elastic#21225) [Ingest Manager] Upgrade Action: make source URI optional (elastic#21372) Add field limit check for AWS Cloudtrail flattened fields (elastic#21388) [Winlogbeat] Move winlogbeat javascript processor to libbeat (elastic#21402) ci: pipeline to generate the changelog (elastic#21426) [JJBB] Set shallow cloning to 10 (elastic#21409) docs: add link to release notes for 7.9.2 (elastic#21405) (elastic#21419) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 2, 2020
…ci-build-label-support * upstream/master: [CI] Change x-pack/auditbeat build events (comments, labels) (elastic#21463) [CI] changeset from elastic#20603 was not added to CI2.0 (elastic#21464) Add new log file reader for filestream input (elastic#21450) [CI] Send slack message with build status (elastic#21428) Remove duplicated sources url in dependencies report (elastic#21462) Add implementation of FSWatcher and FSScanner for filestream (elastic#21444) [Ingest Manager] Split index restrictions into type,dataset, namespace parts (elastic#21406) Update Filebeat module expected logs files (elastic#21454) Edit SQL module docs and fix broken doc structure (elastic#21233) [Ingest Manager] Send snapshot flag together with metadata (elastic#21285) Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447) [JJBB] Use reference repo for fast checkouts (elastic#21410) Add initial skeleton of filestream input (elastic#21427) Initial spec file for apm-server (elastic#21225) [Ingest Manager] Upgrade Action: make source URI optional (elastic#21372) Add field limit check for AWS Cloudtrail flattened fields (elastic#21388) [Winlogbeat] Move winlogbeat javascript processor to libbeat (elastic#21402) ci: pipeline to generate the changelog (elastic#21426)
v1v
added a commit
that referenced
this pull request
Oct 2, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 5, 2020
…-matches-found * upstream/master: (21 commits) Skip filestream flaky tests (elastic#21490) Ignore unsupported metrics in the azure module (elastic#21486) Do not run symlink tests on Windows (elastic#21472) Map `cloud.account.id` to azure sub id (elastic#21483) Add support for app_state metricset (elastic#20639) Include original error when metricbeat fails to connect with Kafka (elastic#21484) Prompt only when agent is already enrolled (elastic#21473) Fix leftover delpoyment example (elastic#21474) Bump version to ECS 1.6 in modules without ECS updates (elastic#21455) Clarify input type configuration options (elastic#19284) Increase index pattern size check to 10MiB (elastic#21487) Migrate S3 Input to Filebeat Input V2 (elastic#20005) [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493) Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467) Fix format of debug messages in tlscommon (elastic#21482) [CI] Change x-pack/auditbeat build events (comments, labels) (elastic#21463) [CI] changeset from elastic#20603 was not added to CI2.0 (elastic#21464) Add new log file reader for filestream input (elastic#21450) [CI] Send slack message with build status (elastic#21428) Remove duplicated sources url in dependencies report (elastic#21462) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Solve python deprecation warnings, and make python tests to fail if deprecated code is added. Changes here: * Add error::DeprecationWarning to pytest's filterwarnings (so tests fail if use deprecated code). * Add pytest.ini to the list of files that trigger all CI builds. * Refactor tests to don't require deprecated assertDictContainsSubset. * Update autopep8 to latest version, and run it once with -a (aggresive). * Solve some other deprecation warnings not solved automatically by autopep8 -a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solve python deprecation warnings, and make python tests to fail if deprecated code is added.
Summary of changes:
error::DeprecationWarningto pytest'sfilterwarnings(so tests fail if use deprecated code).pytest.inito the list of files that trigger all CI builds.assertDictContainsSubset.-a(aggresive).autopep8 -a.Why is it important?
To avoid introducing deprecated Python code on testing.
Checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues