Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for app_state metricset #20639

Merged
merged 44 commits into from
Oct 5, 2020
Merged

Add support for app_state metricset #20639

merged 44 commits into from
Oct 5, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Aug 17, 2020

What does this PR do?

Adds support for light app_state metricset.

Why is it important?

metricbeat-azure-app-state-overview

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Screenshots

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 17, 2020
@narph narph self-assigned this Aug 17, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 17, 2020

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20639 updated]

  • Start Time: 2020-10-02T17:10:05.503+0000

  • Duration: 66 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 1635
Skipped 346
Total 1981

Steps errors

Expand to view the steps failures

  • Name: Extract

    • Description: tar -xpf source.tgz

    • Duration: 1 min 34 sec

    • Start Time: 2020-10-02T17:38:41.971+0000

    • log

  • Name: Error signal

    • Description: untar: step failed with error script returned exit code 1

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-02T17:39:16.015+0000

    • log

  • Name: Extract

    • Description: tar -xpf source.tgz

    • Duration: 1 min 33 sec

    • Start Time: 2020-10-02T17:38:37.711+0000

    • log

  • Name: Error signal

    • Description: untar: step failed with error script returned exit code 1

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-02T17:39:10.921+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-10-02T18:14:49.534Z] 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
[2020-10-02T18:14:49.534Z] 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
[2020-10-02T18:14:49.534Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
[2020-10-02T18:14:49.534Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-10-02T18:14:49.534Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-10-02T18:14:49.534Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-10-02T18:14:49.534Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-10-02T18:14:49.534Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-10-02T18:14:49.534Z] No artifacts found that match the file pattern "**/build/TEST*.out". Configuration error?
[2020-10-02T18:14:49.898Z] + python .ci/scripts/search_system_tests.py
[2020-10-02T18:14:49.919Z] [INFO] system-tests='build/metricbeat/build/system-tests'. If no empty then let's create a tarball
[2020-10-02T18:14:50.257Z] + tar --version
[2020-10-02T18:14:50.602Z] + tar --exclude=metricbeat--system-tests-linux.tgz -czf metricbeat--system-tests-linux.tgz build/metricbeat/build/system-tests
[2020-10-02T18:14:57.213Z] Archiving artifacts
[2020-10-02T18:15:01.901Z] Client: Docker Engine - Community
[2020-10-02T18:15:01.901Z]  Version:           19.03.13
[2020-10-02T18:15:01.901Z]  API version:       1.40
[2020-10-02T18:15:01.901Z]  Go version:        go1.13.15
[2020-10-02T18:15:01.901Z]  Git commit:        4484c46d9d
[2020-10-02T18:15:01.901Z]  Built:             Wed Sep 16 17:02:36 2020
[2020-10-02T18:15:01.901Z]  OS/Arch:           linux/amd64
[2020-10-02T18:15:01.901Z]  Experimental:      false
[2020-10-02T18:15:01.901Z] 
[2020-10-02T18:15:01.901Z] Server: Docker Engine - Community
[2020-10-02T18:15:01.901Z]  Engine:
[2020-10-02T18:15:01.901Z]   Version:          19.03.13
[2020-10-02T18:15:01.901Z]   API version:      1.40 (minimum version 1.12)
[2020-10-02T18:15:01.901Z]   Go version:       go1.13.15
[2020-10-02T18:15:01.901Z]   Git commit:       4484c46d9d
[2020-10-02T18:15:01.901Z]   Built:            Wed Sep 16 17:01:06 2020
[2020-10-02T18:15:01.901Z]   OS/Arch:          linux/amd64
[2020-10-02T18:15:01.901Z]   Experimental:     false
[2020-10-02T18:15:01.901Z]  containerd:
[2020-10-02T18:15:01.901Z]   Version:          1.3.7
[2020-10-02T18:15:01.901Z]   GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
[2020-10-02T18:15:01.901Z]  runc:
[2020-10-02T18:15:01.901Z]   Version:          1.0.0-rc10
[2020-10-02T18:15:01.901Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-10-02T18:15:01.901Z]  docker-init:
[2020-10-02T18:15:01.901Z]   Version:          0.18.0
[2020-10-02T18:15:01.901Z]   GitCommit:        fec3683
[2020-10-02T18:15:12.351Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-10-02T18:15:12.361Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-10-02T18:15:12.429Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-20639-15/source/source.tgz
[2020-10-02T18:15:12.447Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-20639-15/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-20639/source.tgz
[2020-10-02T18:15:24.253Z] + tar --version
[2020-10-02T18:15:24.562Z] + tar -xpf source.tgz
[2020-10-02T18:15:37.121Z] + rm source.tgz
[2020-10-02T18:15:37.188Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats
[2020-10-02T18:15:37.198Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/uncategorized-1601659961573
[2020-10-02T18:15:37.232Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-unitTest-1601660670854
[2020-10-02T18:15:37.270Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-crosscompile-1601661038573
[2020-10-02T18:15:37.303Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/x-pack-metricbeat-build-1601661954693
[2020-10-02T18:15:37.337Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-goIntegTest-1601662343360
[2020-10-02T18:15:37.384Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-pythonIntegTest-1601662488681
[2020-10-02T18:15:37.726Z] + cat
[2020-10-02T18:15:37.726Z] + /usr/local/bin/runbld ./runbld-test-reports --job-name elastic+beats+pull-request
[2020-10-02T18:15:37.726Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-10-02T18:15:44.328Z] runbld>>> runbld started
[2020-10-02T18:15:44.328Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-10-02T18:15:46.244Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-10-02T18:15:46.244Z] runbld>>> Matches in the system config:
[2020-10-02T18:15:46.244Z] runbld>>> - Matched ^elastic\+beats
[2020-10-02T18:15:46.244Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-10-02T18:15:47.633Z] runbld>>> Debug logging enabled.
[2020-10-02T18:15:47.633Z] runbld>>> Storing result
[2020-10-02T18:15:47.895Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-10-02T18:15:47.896Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201002181547-40928B57
[2020-10-02T18:15:47.896Z] runbld>>> Adding system facts.
[2020-10-02T18:15:48.844Z] runbld>>> Adding vcs info for the latest commit:  5d832c17f0f02ff8712eadfaabc2d0a78bfd9acd
[2020-10-02T18:15:48.844Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-10-02T18:15:49.106Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-10-02T18:15:49.106Z] + echo 'Processing JUnit reports with runbld...'
[2020-10-02T18:15:49.106Z] Processing JUnit reports with runbld...
[2020-10-02T18:15:49.368Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-10-02T18:15:49.368Z] runbld>>> DURATION: 30ms
[2020-10-02T18:15:49.368Z] runbld>>> STDOUT: 40 bytes
[2020-10-02T18:15:49.368Z] runbld>>> STDERR: 49 bytes
[2020-10-02T18:15:49.368Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-10-02T18:15:49.368Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20639
[2020-10-02T18:15:50.322Z] runbld>>> Storing build metadata: 
[2020-10-02T18:15:50.322Z] runbld>>> Adding test report.
[2020-10-02T18:15:50.322Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats
[2020-10-02T18:15:51.265Z] runbld>>> Found 46 test output files
[2020-10-02T18:15:51.527Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-goIntegTest-1601662343360/metricbeat/build/TEST-go-integration-graphite.xml
[2020-10-02T18:15:51.527Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-20639/src/github.com/elastic/beats/metricbeat-goIntegTest-1601662343360/metricbeat/build/TEST-go-integration-windows.xml
[2020-10-02T18:15:52.106Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 1981 Skipped: 210
[2020-10-02T18:15:52.106Z] runbld>>> Storing result
[2020-10-02T18:15:52.106Z] runbld>>> FAILURES: 0
[2020-10-02T18:15:52.367Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-10-02T18:15:52.367Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201002181547-40928B57
[2020-10-02T18:15:52.628Z] runbld>>> Email notification disabled by environment variable.
[2020-10-02T18:15:52.628Z] runbld>>> Slack notification disabled by environment variable.
[2020-10-02T18:15:58.183Z] Running on worker-1244230 in /var/lib/jenkins/workspace/Beats_beats_PR-20639
[2020-10-02T18:15:58.308Z] [INFO] getVaultSecret: Getting secrets
[2020-10-02T18:15:58.515Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-02T18:16:00.397Z] + chmod 755 generate-build-data.sh
[2020-10-02T18:16:00.397Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20639/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20639/runs/15 FAILURE 3953495
[2020-10-02T18:16:00.397Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20639/runs/15/steps/?limit=10000 -o steps-info.json
[2020-10-02T18:16:04.611Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20639/runs/15/tests/?status=FAILED -o tests-errors.json

@andresrc
Copy link
Contributor

Related: #19881

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Aug 18, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 18, 2020
@narph narph marked this pull request as ready for review October 2, 2020 13:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. labels Oct 2, 2020

include::../../../../x-pack/metricbeat/module/azure/app_state/_meta/docs.asciidoc[]

This is a default metricset. If the host module is unconfigured, this metricset is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats host module here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, it was set as default in the manifest file

@@ -4,5 +4,6 @@ metricsets:
- container_instance
- container_service
- database_account
- app_state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe rewrite this list in alphabetical order?

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@narph narph merged commit 67a2d38 into elastic:master Oct 5, 2020
@narph narph deleted the app_stats branch October 5, 2020 08:52
narph added a commit to narph/beats that referenced this pull request Oct 5, 2020
* mofidy doc

* add metricset

* chnagelog

* config

* work on app_state

* remove extra

* fix changelog

* mage fmt update

* work on mapping fields

* work on tests

* fix vis name

* no default

* fix tests

* add headers

(cherry picked from commit 67a2d38)
narph added a commit that referenced this pull request Oct 5, 2020
* mofidy doc

* add metricset

* chnagelog

* config

* work on app_state

* remove extra

* fix changelog

* mage fmt update

* work on mapping fields

* work on tests

* fix vis name

* no default

* fix tests

* add headers

(cherry picked from commit 67a2d38)
v1v added a commit to v1v/beats that referenced this pull request Oct 5, 2020
…-matches-found

* upstream/master: (21 commits)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  [CI] Change x-pack/auditbeat build events (comments, labels) (elastic#21463)
  [CI] changeset from elastic#20603 was not added to CI2.0 (elastic#21464)
  Add new log file reader for filestream input (elastic#21450)
  [CI] Send slack message with build status (elastic#21428)
  Remove duplicated sources url in dependencies report (elastic#21462)
  ...
@narph narph added the v7.10.0 label Oct 5, 2020
v1v added a commit to v1v/beats that referenced this pull request Oct 5, 2020
* upstream/master: (26 commits)
  [Ingest Manager] Send updating state (elastic#21461)
  [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504)
  [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
  Implementation of fileProspector (elastic#21479)
  [Metricbeat] Add latency config option into aws module (elastic#20875)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team v7.10.0 [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants