-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Send updating state #21461
Merged
michalpristas
merged 5 commits into
elastic:master
from
michalpristas:agent-report-upgrading
Oct 5, 2020
Merged
[Ingest Manager] Send updating state #21461
michalpristas
merged 5 commits into
elastic:master
from
michalpristas:agent-report-upgrading
Oct 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
enhancement
needs_backport
PR is waiting to be backported to other branches.
Team:Ingest Management
Ingest Management:beta2
Group issues for ingest management beta2
labels
Oct 2, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Oct 2, 2020
Collaborator
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
blakerouse
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 5, 2020
[Ingest Manager] Send updating state (elastic#21461)
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 5, 2020
* upstream/master: (26 commits) [Ingest Manager] Send updating state (elastic#21461) [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504) [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488) Implementation of fileProspector (elastic#21479) [Metricbeat] Add latency config option into aws module (elastic#20875) Skip filestream flaky tests (elastic#21490) Ignore unsupported metrics in the azure module (elastic#21486) Do not run symlink tests on Windows (elastic#21472) Map `cloud.account.id` to azure sub id (elastic#21483) Add support for app_state metricset (elastic#20639) Include original error when metricbeat fails to connect with Kafka (elastic#21484) Prompt only when agent is already enrolled (elastic#21473) Fix leftover delpoyment example (elastic#21474) Bump version to ECS 1.6 in modules without ECS updates (elastic#21455) Clarify input type configuration options (elastic#19284) Increase index pattern size check to 10MiB (elastic#21487) Migrate S3 Input to Filebeat Input V2 (elastic#20005) [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493) Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467) Fix format of debug messages in tlscommon (elastic#21482) ...
michalpristas
added a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Ingest Management:beta2
Group issues for ingest management beta2
needs_backport
PR is waiting to be backported to other branches.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reports updating state of application after update process is started and error in case it is finished with failure
Tested with elastic/kibana#78810 after suggested changes (i did them manually) i started agent without starting a file server so UPDATE fails i got this (as expected)
UPDATE is ACK-ed and Error there is reported, under ACK there is line saying STATE was switched to UPDATING
after i started server and rekicked UPDATE action
update was ACKed and state switched to RUNNING after it finished.
Status on list page was
ONLINE
thenUPDATING
and then backONLINE
. Even though there were errors, so i guess this will be an object of next iteration.Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.