Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill cloud.account.name with accountID if account alias doesn't exist #20736

Merged
merged 3 commits into from
Aug 23, 2020
Merged

Fill cloud.account.name with accountID if account alias doesn't exist #20736

merged 3 commits into from
Aug 23, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to make sure cloud.account.name is not empty even when account alias/name does not exist. This is required because dashboards for aws module requires cloud.account.name as a filter.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 21, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Aug 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 21, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 21, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20736 updated]

  • Start Time: 2020-08-23T00:33:28.647+0000

  • Duration: 52 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 833
Skipped 72
Total 905

jsoriano
jsoriano approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noticed a small detail.

x-pack/metricbeat/module/aws/aws.go Outdated Show resolved Hide resolved
@kaiyan-sheng kaiyan-sheng merged commit d2a0999 into elastic:master Aug 23, 2020
@kaiyan-sheng kaiyan-sheng deleted the aws_account_name branch August 23, 2020 15:02
@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 23, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 23, 2020
kaiyan-sheng added a commit that referenced this pull request Aug 26, 2020
@kaiyan-sheng
Cherry-pick #20736 to 7.x: Fill cloud.account.name with accountID if …
902d916 
…account alias doesn't exist (#20745)

* Fill cloud.account.name with accountID if account alias doesn't exist (#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit d2a0999)
@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 27, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Aug 31, 2020
@kaiyan-sheng
Cherry-pick #20736 to 7.9: Fill cloud.account.name with accountID if …
80db33a 
…account alias doesn't exist (#20835)

* Fill cloud.account.name with accountID if account alias doesn't exist (#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit d2a0999)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kaiyan-sheng @melchiormoulin
Fill cloud.account.name with accountID if account alias doesn't exist (…
abe473a 
…elastic#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#20736 to 7.9: Fill cloud.account.name with accoun…
f35671b 
…tID if account alias doesn't exist (elastic#20835)

* Fill cloud.account.name with accountID if account alias doesn't exist (elastic#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit bae7b38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.9.1 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @jsoriano