Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20736 to 7.x: Fill cloud.account.name with accountID if account alias doesn't exist #20745

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Cherry-pick #20736 to 7.x: Fill cloud.account.name with accountID if account alias doesn't exist #20745

merged 3 commits into from
Aug 26, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 23, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20736 to 7.x branch. Original message:

This PR is to make sure cloud.account.name is not empty even when account alias/name does not exist. This is required because dashboards for aws module requires cloud.account.name as a filter.

@kaiyan-sheng
Fill cloud.account.name with accountID if account alias doesn't exist (…
1af353e 
…#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit d2a0999)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 23, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 23, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 23, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20745 updated]

  • Start Time: 2020-08-24T19:22:00.508+0000

  • Duration: 56 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 833
Skipped 72
Total 905

@kaiyan-sheng kaiyan-sheng merged commit 902d916 into elastic:7.x Aug 26, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20736_7.x branch August 26, 2020 21:32
@zube zube bot removed the [zube]: Done label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @jsoriano