-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Refactor Suricata pipeline to use Ingest Node more #22291
[Filebeat] Refactor Suricata pipeline to use Ingest Node more #22291
Conversation
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
53a9c67
to
e75c87e
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively. Other changes - Added DNS response IPs to `related.ip`. - Some DNS events were missing `dns.header_flags`.
e75c87e
to
abd075e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I did notice that pipeline.yml is basically switching off the
ctx.suricata.eve.event_type
value to set event.type
and
network.protocol
. What do you think about moving those to a
painless script with params? Like
- script: |
…beats into feature/suricata-ingest-node
@leehinman Will you please take another look at the changes I made to adopt the script idea. |
Looks great. 👍 |
…c#22291) Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively. Other changes - Added DNS response IPs to `related.ip`. - Some DNS events were missing `dns.header_flags`. (cherry picked from commit 2fe9e2a)
#22453) Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively. Other changes - Added DNS response IPs to `related.ip`. - Some DNS events were missing `dns.header_flags`. (cherry picked from commit 2fe9e2a)
…c#22291) Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively. Other changes - Added DNS response IPs to `related.ip`. - Some DNS events were missing `dns.header_flags`. (cherry picked from commit 2fe9e2a)
#22583) Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively. Other changes - Added DNS response IPs to `related.ip`. - Some DNS events were missing `dns.header_flags`. (cherry picked from commit 2fe9e2a)
What does this PR do?
Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively.
Other changes
related.ip
.dns.header_flags
.Why is it important?
Hopefully by reducing processing in Filebeat this week increase the throughput of the Suricata module. Testing to follow.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.