-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Enable log shipping of endpoint-security by Elastic Agent #22526
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
@blakerouse do we have everything we need in the data send from endpoint to make sure we can display the log of the endpoint in the logstream UI made by @jen-huang. ? |
@ph Yes it included the agent ID in the events so the LogStream component can show these logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change, probably will make future changes simpler.
i left a comments but they are related to segmented imports. nothing critical
…gent (elastic#22526) * Refactor to pass program.Spec around so custom log paths can be defined in a program spec. * Fix code. * Fix formatting. * Add changelog. * Fixes from code review. (cherry picked from commit 4c2c647)
@blakerouse Can add details on the following for testing that change: AC:
Fyi @EricDavisX |
Should really need to worry about the log location, well unless it doesn't work ;-) The events will have show up in the Logs UI. Easiest to filter by |
@blakerouse but there are sent to a distinct datastream right? |
@ph Yes should be similar to dataset name |
The PR and the issue are closed (which is ok!) so I've logged a test tracking issue for any remaining discussion questions about test coverage. #22549 |
@blakerouse We can't use |
Created this issue as a followup #22551 |
What does this PR do?
Starts shipping the logs of endpoint-security to elasticsearch.
This also refactors the code some to pass the
program.Spec
around instead of needing to keep checking for it from the SupportedMap. This is how the code path determines the path for the endpoint-security log paths.Why is it important?
So all log information from an Elastic Agent running endpoint-security can be observed.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Build the Elastic Agent with endpoint-security manually placed in the download folder. Enable Endpoint Security in Fleet and notice that all the Endpoint Security logs show up with
event.dataset: elastic_agent.endpoint-security
Related issues