Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22526 to 7.x: [Elastic Agent] Enable log shipping of endpoint-security by Elastic Agent #22547

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #22526 to 7.x branch. Original message:

What does this PR do?

Starts shipping the logs of endpoint-security to elasticsearch.

This also refactors the code some to pass the program.Spec around instead of needing to keep checking for it from the SupportedMap. This is how the code path determines the path for the endpoint-security log paths.

Why is it important?

So all log information from an Elastic Agent running endpoint-security can be observed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Build the Elastic Agent with endpoint-security manually placed in the download folder. Enable Endpoint Security in Fleet and notice that all the Endpoint Security logs show up with event.dataset: elastic_agent.endpoint-security

Related issues

…gent (elastic#22526)

* Refactor to pass program.Spec around so custom log paths can be defined in a program spec.

* Fix code.

* Fix formatting.

* Add changelog.

* Fixes from code review.

(cherry picked from commit 4c2c647)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 11, 2020
@blakerouse blakerouse self-assigned this Nov 11, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22547 opened]

  • Start Time: 2020-11-11T16:14:16.076+0000

  • Duration: 28 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good

@blakerouse blakerouse merged commit ed07adb into elastic:7.x Nov 16, 2020
@blakerouse blakerouse deleted the backport_22526_7.x branch November 16, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants