Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Filebeat test_shutdown on windows 7 #22797

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Skip Filebeat test_shutdown on windows 7 #22797

merged 1 commit into from
Nov 30, 2020

Conversation

urso
Copy link

@urso urso commented Nov 30, 2020

Flaky Test

What does this PR do?

Skip filebeat.tests.system.test_shutdown.Test.test_shutdown on Windows-7.

Why is it important?

The test seems to be unstable on Windows 7 (32 Bit).

Checklist

  • My code follows the style guidelines of this project

Related issues

@urso urso added review needs_backport PR is waiting to be backported to other branches. flaky-test Unstable or unreliable test cases. labels Nov 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2020
@botelastic
Copy link

botelastic bot commented Nov 30, 2020

This pull request doesn't have a Team:<team> label.

@urso urso mentioned this pull request Nov 30, 2020
Merged
1 task
@urso urso added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 30, 2020
michalpristas
michalpristas approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22797 opened

  • Start Time: 2020-11-30T17:18:41.293+0000

  • Duration: 34 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 2545
Skipped 306
Total 2851

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2545
Skipped 306
Total 2851

@urso urso merged commit 5038ccf into elastic:master Nov 30, 2020
@urso urso deleted the windows-7-skip-test_shutdown branch November 30, 2020 18:27
urso pushed a commit that referenced this pull request Nov 30, 2020
Cherry-pick #22797 to 7.x: Skip Filebeat test_shutdown on windows 7 (#…
ffd3c9b 
…22798)

(cherry picked from commit c408b5e)
v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7…
6724419 
…-issues

* upstream/master: (41 commits)
  Fix version parser regex for packaging (elastic#22581)
  Fix local_dynamic documentation and add providers inline doc. (elastic#22657)
  fix: use proper param name for e2e tests (elastic#22836)
  [Heartbeat] Fix exit on disabled monitor (elastic#22829)
  Update Golang to 1.14.12 (elastic#22790)
  docs: fix setup.template.overwrite typos (elastic#22804)
  Add docs section for ECS EC2 monitoring (elastic#22784)
  Fixing logic to keep list of unique cluster UUIDs (elastic#22808)
  Skip somewhat flaky UDP system test on Windows (elastic#22810)
  Fix polling node when it is not ready and monitor by hostname (elastic#22666)
  Skip Filebeat test_shutdown on windows 7 (elastic#22797)
  Make monitoring Namespace thread-safe (elastic#22640)
  Drop pkt_dstaddr and pkt_srcaddr when equals to "-" (elastic#22721)
  Add support for reading from UNIX datagram sockets (elastic#22699)
  Fix export dashboard command from Elastic Cloud (elastic#22746)
  Skip flaky winlogbeat test on Windows-7 (elastic#22754)
  Missing `>` (elastic#22763) (elastic#22766)
  Fix k8s watcher issue when node access to list nodes and ns (elastic#22714)
  [Metricbeat/Kibana/stats] Enforce `exclude_usage=true` (elastic#22732)
  Avoid sending non-numeric floats in cloud foundry integrations (elastic#22634)
  ...
v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/retry-win…
29404d9 
…dows-7

* upstream/master: (41 commits)
  Fix version parser regex for packaging (elastic#22581)
  Fix local_dynamic documentation and add providers inline doc. (elastic#22657)
  fix: use proper param name for e2e tests (elastic#22836)
  [Heartbeat] Fix exit on disabled monitor (elastic#22829)
  Update Golang to 1.14.12 (elastic#22790)
  docs: fix setup.template.overwrite typos (elastic#22804)
  Add docs section for ECS EC2 monitoring (elastic#22784)
  Fixing logic to keep list of unique cluster UUIDs (elastic#22808)
  Skip somewhat flaky UDP system test on Windows (elastic#22810)
  Fix polling node when it is not ready and monitor by hostname (elastic#22666)
  Skip Filebeat test_shutdown on windows 7 (elastic#22797)
  Make monitoring Namespace thread-safe (elastic#22640)
  Drop pkt_dstaddr and pkt_srcaddr when equals to "-" (elastic#22721)
  Add support for reading from UNIX datagram sockets (elastic#22699)
  Fix export dashboard command from Elastic Cloud (elastic#22746)
  Skip flaky winlogbeat test on Windows-7 (elastic#22754)
  Missing `>` (elastic#22763) (elastic#22766)
  Fix k8s watcher issue when node access to list nodes and ns (elastic#22714)
  [Metricbeat/Kibana/stats] Enforce `exclude_usage=true` (elastic#22732)
  Avoid sending non-numeric floats in cloud foundry integrations (elastic#22634)
  ...
@jsoriano jsoriano mentioned this pull request Jan 29, 2021
Merged
1 task
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jan 29, 2021
@jsoriano
Skip Filebeat test_shutdown on windows 7 (elastic#22797)
11766b4 
(cherry picked from commit 5038ccf)
jsoriano added a commit that referenced this pull request Jan 30, 2021
@jsoriano
Skip Filebeat test_shutdown on windows 7 (#22797) (#23754)
e4a8a1a 
(cherry picked from commit 5038ccf)

Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Skip Filebeat test_shutdown on windows 7 (elastic#22797) (elastic#23754)
22051d0 
(cherry picked from commit 9574271)

Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@michalpristas michalpristas michalpristas approved these changes

Assignees
No one assigned
Labels
flaky-test Unstable or unreliable test cases. needs_team Indicates that the issue/PR needs a Team:* label review v7.10.3 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@urso @elasticmachine @jsoriano @michalpristas