Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local_dynamic documentation and add providers inline doc. #22657

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Fix local_dynamic documentation and add providers inline doc. #22657

merged 3 commits into from
Dec 1, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 18, 2020

Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Fix local_dynamic documentation and add providers inline doc.
b274f92 
Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.
@ph ph added docs review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management labels Nov 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22657 updated]

  • Start Time: 2020-11-23T14:40:26.393+0000

  • Duration: 19 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 1396
Skipped 4
Total 1400

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1396
Skipped 4
Total 1400

blakerouse
blakerouse approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than my one comment.

x-pack/elastic-agent/_meta/config/providers.yml.tmpl Outdated Show resolved Hide resolved
@ph ph merged commit 4b30d9a into elastic:master Dec 1, 2020
@ph ph mentioned this pull request Dec 1, 2020
Merged
6 tasks
@ph ph added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 1, 2020
ph added a commit to ph/beats that referenced this pull request Dec 1, 2020
@ph
Fix local_dynamic documentation and add providers inline doc. (elasti…
b4ffe24 
…c#22657)

* Fix local_dynamic documentation and add providers inline doc.

Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.

* Update docker yml

* enable should be true in the yaml

(cherry picked from commit 4b30d9a)
ph added a commit that referenced this pull request Dec 1, 2020
@ph
Fix local_dynamic documentation and add providers inline doc. (#22657) (
6efd065 
#22840)

* Fix local_dynamic documentation and add providers inline doc.

Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.

* Update docker yml

* enable should be true in the yaml

(cherry picked from commit 4b30d9a)
v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7…
6724419 
…-issues

* upstream/master: (41 commits)
  Fix version parser regex for packaging (elastic#22581)
  Fix local_dynamic documentation and add providers inline doc. (elastic#22657)
  fix: use proper param name for e2e tests (elastic#22836)
  [Heartbeat] Fix exit on disabled monitor (elastic#22829)
  Update Golang to 1.14.12 (elastic#22790)
  docs: fix setup.template.overwrite typos (elastic#22804)
  Add docs section for ECS EC2 monitoring (elastic#22784)
  Fixing logic to keep list of unique cluster UUIDs (elastic#22808)
  Skip somewhat flaky UDP system test on Windows (elastic#22810)
  Fix polling node when it is not ready and monitor by hostname (elastic#22666)
  Skip Filebeat test_shutdown on windows 7 (elastic#22797)
  Make monitoring Namespace thread-safe (elastic#22640)
  Drop pkt_dstaddr and pkt_srcaddr when equals to "-" (elastic#22721)
  Add support for reading from UNIX datagram sockets (elastic#22699)
  Fix export dashboard command from Elastic Cloud (elastic#22746)
  Skip flaky winlogbeat test on Windows-7 (elastic#22754)
  Missing `>` (elastic#22763) (elastic#22766)
  Fix k8s watcher issue when node access to list nodes and ns (elastic#22714)
  [Metricbeat/Kibana/stats] Enforce `exclude_usage=true` (elastic#22732)
  Avoid sending non-numeric floats in cloud foundry integrations (elastic#22634)
  ...
v1v added a commit to v1v/beats that referenced this pull request Dec 2, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/retry-win…
29404d9 
…dows-7

* upstream/master: (41 commits)
  Fix version parser regex for packaging (elastic#22581)
  Fix local_dynamic documentation and add providers inline doc. (elastic#22657)
  fix: use proper param name for e2e tests (elastic#22836)
  [Heartbeat] Fix exit on disabled monitor (elastic#22829)
  Update Golang to 1.14.12 (elastic#22790)
  docs: fix setup.template.overwrite typos (elastic#22804)
  Add docs section for ECS EC2 monitoring (elastic#22784)
  Fixing logic to keep list of unique cluster UUIDs (elastic#22808)
  Skip somewhat flaky UDP system test on Windows (elastic#22810)
  Fix polling node when it is not ready and monitor by hostname (elastic#22666)
  Skip Filebeat test_shutdown on windows 7 (elastic#22797)
  Make monitoring Namespace thread-safe (elastic#22640)
  Drop pkt_dstaddr and pkt_srcaddr when equals to "-" (elastic#22721)
  Add support for reading from UNIX datagram sockets (elastic#22699)
  Fix export dashboard command from Elastic Cloud (elastic#22746)
  Skip flaky winlogbeat test on Windows-7 (elastic#22754)
  Missing `>` (elastic#22763) (elastic#22766)
  Fix k8s watcher issue when node access to list nodes and ns (elastic#22714)
  [Metricbeat/Kibana/stats] Enforce `exclude_usage=true` (elastic#22732)
  Avoid sending non-numeric floats in cloud foundry integrations (elastic#22634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@dedemorton dedemorton Awaiting requested review from dedemorton

Assignees

@ph ph

Labels
docs review v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @blakerouse