Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #22657 to 7.x: Fix local_dynamic documentation and add providers inline doc. #22840

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Cherry-pick #22657 to 7.x: Fix local_dynamic documentation and add providers inline doc. #22840

merged 1 commit into from
Dec 1, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Dec 1, 2020

Cherry-pick of PR #22657 to 7.x branch. Original message:

Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Fix local_dynamic documentation and add providers inline doc. (elasti…
b4ffe24 
…c#22657)

* Fix local_dynamic documentation and add providers inline doc.

Fix issues with the configuration and usage of the local_dynamic
provider and add inline documentation in the yaml files.

* Update docker yml

* enable should be true in the yaml

(cherry picked from commit 4b30d9a)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 1, 2020
@ph ph requested a review from blakerouse December 1, 2020 21:12
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22840 opened

  • Start Time: 2020-12-01T21:13:05.643+0000

  • Duration: 32 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

blakerouse
blakerouse approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@ph ph merged commit 6efd065 into elastic:7.x Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees
No one assigned
Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @blakerouse