-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apache status: adjust field collection in fleet mode #22821
Merged
mtojek
merged 7 commits into
elastic:master
from
mtojek:370-apache-adjust-collected-fields
Dec 3, 2020
Merged
Apache status: adjust field collection in fleet mode #22821
mtojek
merged 7 commits into
elastic:master
from
mtojek:370-apache-adjust-collected-fields
Dec 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Dec 1, 2020
Collaborator
Test passed:
|
Pinging @elastic/integrations (Team:Integrations) |
16 tasks
jsoriano
reviewed
Dec 2, 2020
jsoriano
approved these changes
Dec 2, 2020
@jsoriano Thank you for the approval! What are the current rules of merging the PR considering there are two failed checks (not related to this PR)? |
Ok, I see that the relevant test passed. I'm merging this one. |
6 tasks
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Dec 3, 2020
* apache status: adjust collected fields in fleet mode * Fix: mage check * Update CHANGELOG * nit-pick * Address PR comments (cherry picked from commit 0c1e54c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modified field collection log in the Apache module, "status" metricset, so they're collected according to expectations of the Apache Integration.
apache.status.hostname
->host.hostname
(already present)(decided not to proceed with this change.apache.status.uptime.uptime
- >host.uptime
host.uptime
has a different meaning)Why is it important?
Migration to Beats (elastic/integrations#370)
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
(there is an integration test)
Related issues
Use cases
Screenshots
Logs