Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add regenerated rsa2elk modules with subdomain processors #23035

Merged
merged 12 commits into from
Dec 14, 2020
Merged

[Filebeat] Add regenerated rsa2elk modules with subdomain processors #23035

merged 12 commits into from
Dec 14, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Dec 9, 2020 •
edited
Loading

What does this PR do?

This imports regenerated rsa2elk modules based off of the changes in adriansr/nwdevice2filebeat#10

The changes allow us to fill in registered_domain and subdomain every place we have those fields available in ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki requested review from adriansr and a team December 9, 2020 17:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@andrewstucki andrewstucki mentioned this pull request Dec 9, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 9, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23035 updated

  • Start Time: 2020-12-14T15:47:42.413+0000

  • Duration: 56 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 2426
Skipped 261
Total 2687

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2426
Skipped 261
Total 2687

@adriansr adriansr merged commit 2988c49 into elastic:master Dec 14, 2020
@andrewstucki andrewstucki deleted the rsa2elk-subdomains branch December 14, 2020 18:17
@adriansr adriansr mentioned this pull request Dec 14, 2020
Merged
6 tasks
adriansr pushed a commit to adriansr/beats that referenced this pull request Dec 14, 2020
@adriansr
[Filebeat] Add regenerated rsa2elk modules with subdomain processors (e…
b388335 
…lastic#23035)

Changed rsa2elk modules with registered_domain and subdomain every place we have those fields available in ECS.

(cherry picked from commit 2988c49)
adriansr added a commit that referenced this pull request Dec 14, 2020
@adriansr
[Filebeat] Add regenerated rsa2elk modules with subdomain processors (#…
95a83b0 
…23035) (#23119)

Changed rsa2elk modules with registered_domain and subdomain every place we have those fields available in ECS.

(cherry picked from commit 2988c49)

Co-authored-by: Andrew Stucki <andrew.stucki@elastic.co>
@111andre111 111andre111 mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
ecs enhancement Filebeat Filebeat v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @adriansr