Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in Journalbeat commands #24880

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fix error in Journalbeat commands #24880

merged 1 commit into from
Apr 3, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Apr 1, 2021 •
edited
Loading

What does this PR do?

Fixes bug in widget code that caused incorrect commands to render in the docs.

Why is it important?

The documented command would not work on the platform given.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@dedemorton dedemorton added docs review needs_backport PR is waiting to be backported to other branches. labels Apr 1, 2021
@dedemorton dedemorton requested a review from a team April 1, 2021 03:40
@dedemorton dedemorton self-assigned this Apr 1, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2021
@dedemorton dedemorton mentioned this pull request Apr 1, 2021
Closed
@dedemorton dedemorton removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24880 opened

  • Start Time: 2021-04-01T03:41:13.461+0000

  • Duration: 22 min 54 sec

  • Commit: a8e779c

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@dedemorton dedemorton merged commit f9df326 into elastic:master Apr 3, 2021
@dedemorton dedemorton deleted the issue#24846 branch April 3, 2021 01:46
@dedemorton dedemorton mentioned this pull request Apr 3, 2021
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 3, 2021
@dedemorton
Fix error in Journalbeat commands (elastic#24880)
a6ee81f
@dedemorton dedemorton mentioned this pull request Apr 3, 2021
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 3, 2021
@dedemorton
Fix error in Journalbeat commands (elastic#24880)
94c87a9
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 3, 2021
@dedemorton
Fix error in Journalbeat commands (elastic#24880)
e2de61a
@dedemorton dedemorton mentioned this pull request Apr 3, 2021
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 3, 2021
@dedemorton
Fix error in Journalbeat commands (elastic#24880)
d9b2785
@dedemorton dedemorton mentioned this pull request Apr 3, 2021
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 3, 2021
@dedemorton
Fix error in Journalbeat commands (elastic#24880)
59db876
@dedemorton dedemorton mentioned this pull request Apr 3, 2021
Merged
dedemorton added a commit that referenced this pull request Apr 5, 2021
@dedemorton
Fix error in Journalbeat commands (#24880) (#24920)
0dfcf36
dedemorton added a commit that referenced this pull request Apr 5, 2021
@dedemorton
Fix error in Journalbeat commands (#24880) (#24921)
f9aabc2
dedemorton added a commit that referenced this pull request Apr 5, 2021
@dedemorton
Fix error in Journalbeat commands (#24880) (#24923)
5121973
dedemorton added a commit that referenced this pull request Apr 5, 2021
@dedemorton
Fix error in Journalbeat commands (#24880) (#24922)
cdee625
dedemorton added a commit that referenced this pull request Apr 5, 2021
@dedemorton
Fix error in Journalbeat commands (#24880) (#24924)
842f11d
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Apr 5, 2021
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Apr 7, 2021
@dedemorton @michalpristas
Fix error in Journalbeat commands (elastic#24880)
d85b239
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/mergify
c1238b8 
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
@dikshachauhan-qasource
Copy link

dikshachauhan-qasource commented Apr 8, 2021 •
edited
Loading

Hi @dedemorton cc @EricDavisX

We have revalidated this issue and found it fixed at link: journalbeat installation guide

Screenshot for reference:
image

Thanks
QAS

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton
Fix error in Journalbeat commands (elastic#24880) (elastic#24924)
fc58a57
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton
Fix error in Journalbeat commands (elastic#24880) (elastic#24923)
39498ba
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton
Fix error in Journalbeat commands (elastic#24880) (elastic#24922)
68dc2d2
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@dedemorton
Fix error in Journalbeat commands (elastic#24880) (elastic#24921)
29d4fc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@dedemorton dedemorton

Labels
docs needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error for journalbeat installation at setup command on user guide page.
4 participants
@dedemorton @elasticmachine @dikshachauhan-qasource @bmorelli25