Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to delete indices with wildcards in testing #24915

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix ability to delete indices with wildcards in testing #24915

merged 1 commit into from
Apr 2, 2021

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Apr 2, 2021 •
edited
Loading

What does this PR do?

Looks like a recent commit to Elasticsearch broke CI in some builds that run libbeat tests. Here's the commit:

elastic/elasticsearch@60f4d22

Here's an example build break:

[2021-04-01T21:57:08.934Z] tests/system/idxmgmt.py:31: in delete_index_and_alias
[2021-04-01T21:57:08.934Z]     self._client.transport.perform_request('DELETE', "/" + index + "*")
[2021-04-01T21:57:08.934Z] ../build/ve/docker/lib/python3.7/site-packages/elasticsearch/transport.py:352: in perform_request
[2021-04-01T21:57:08.934Z]     timeout=timeout,
[2021-04-01T21:57:08.934Z] ../build/ve/docker/lib/python3.7/site-packages/elasticsearch/connection/http_urllib3.py:256: in perform_request
[2021-04-01T21:57:08.934Z]     self._raise_error(response.status, raw_data)
[2021-04-01T21:57:08.934Z] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
[2021-04-01T21:57:08.934Z] 
[2021-04-01T21:57:08.934Z] self = <Urllib3HttpConnection: http://elasticsearch:9200>, status_code = 400
[2021-04-01T21:57:08.934Z] raw_data = '{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Wildcard expressions or all indices are not al...d"}],"type":"illegal_argument_exception","reason":"Wildcard expressions or all indices are not allowed"},"status":400}'

From:

#24909

@andrewstucki andrewstucki requested a review from a team April 2, 2021 12:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 2, 2021
P1llus
P1llus approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh
Copy link
Member

Relates: elastic/elasticsearch#66908

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 2, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Andrew Stucki

  • Start Time: 2021-04-02T15:45:40.005+0000

  • Duration: 67 min 6 sec

  • Commit: bc4daec

Test stats 🧪

Test Results
Failed 0
Passed 46544
Skipped 5132
Total 51676

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46544
Skipped 5132
Total 51676

@andrewstucki andrewstucki merged commit 6ae56ad into elastic:master Apr 2, 2021
@andrewstucki andrewstucki deleted the build-fix-delete branch April 2, 2021 16:55
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Apr 7, 2021
@michalpristas
Add ability to destroy indices with wildcards in testing (elastic#24915)
965db5e
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/mergify
c1238b8 
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewstucki @elasticmachine @andrewkroh @P1llus