Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24966 to 7.x: [filebeat] Debug empty root field instead of error #24970

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 7, 2021

Cherry-pick of PR #24966 to 7.x branch. Original message:

What does this PR do?

Do not log errors when the root field of a split is empty. Print it as a debug message instead.

Why is it important?

Root field being empty is usually due to the response is empty/there are no more events, so printing it as an error cause confusion.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24970 opened

  • Start Time: 2021-04-07T13:57:39.192+0000

  • Duration: 63 min 34 sec

  • Commit: a7f311b

Test stats 🧪

Test Results
Failed 0
Passed 6838
Skipped 1185
Total 8023

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6838
Skipped 1185
Total 8023

@marc-gr marc-gr merged commit 182ed99 into elastic:7.x Apr 7, 2021
@marc-gr marc-gr deleted the backport_24966_7.x branch April 7, 2021 15:04
@zube zube bot removed the [zube]: Done label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants