Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] Debug empty root field instead of error #24966

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 7, 2021

What does this PR do?

Do not log errors when the root field of a split is empty. Print it as a debug message instead.

Why is it important?

Root field being empty is usually due to the response is empty/there are no more events, so printing it as an error cause confusion.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr added needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Apr 7, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 7, 2021
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24966 opened

  • Start Time: 2021-04-07T12:41:13.987+0000

  • Duration: 67 min 6 sec

  • Commit: 3e68c1e

Test stats 🧪

Test Results
Failed 0
Passed 6865
Skipped 1185
Total 8050

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6865
Skipped 1185
Total 8050

@marc-gr marc-gr merged commit ead29fc into elastic:master Apr 7, 2021
@marc-gr marc-gr deleted the fix_httpjson_no_err_on_empty_root branch April 7, 2021 13:49
marc-gr added a commit to marc-gr/beats that referenced this pull request Apr 7, 2021
@marc-gr marc-gr added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 7, 2021
marc-gr added a commit that referenced this pull request Apr 7, 2021
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
…eline

* upstream/master:
  CI: curl seems to be available but where cannot find it (elastic#24965)
  [mergify] backport automation to 7.x, 7.12 and 7.11 (elastic#24608)
  Only show deprecation warnings for CN-based verification once (elastic#24948)
  CI: use ubuntu-20 (elastic#24963)
  Debug empty root field instead of error (elastic#24966)
  Kubernetes_secrets provider improvements (elastic#24912)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants