Only show deprecation warnings for CN-based verification once #24948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
approved these changes
Apr 7, 2021
Merged
1 task
andrewstucki
added
v7.13.0
and removed
needs_backport
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 7, 2021
…eline * upstream/master: CI: curl seems to be available but where cannot find it (elastic#24965) [mergify] backport automation to 7.x, 7.12 and 7.11 (elastic#24608) Only show deprecation warnings for CN-based verification once (elastic#24948) CI: use ubuntu-20 (elastic#24963) Debug empty root field instead of error (elastic#24966) Kubernetes_secrets provider improvements (elastic#24912)
andrewstucki
pushed a commit
that referenced
this pull request
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I haven't tracked down all of the code paths that call
Validate, but customers are complaining about how much noise this deprecation warning is adding to their logs. I think it makes sense just to warn once, so it should be enough just to wrap this in a globalsync.Once.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.