Kubernetes_secrets provider improvements #24912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
review
needs_backport
botelastic
bot
added
the
needs_team
ChrsMark
added
Team:Elastic-Agent
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
@blakerouse could you have a look into this one please? |
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Apr 7, 2021
Signed-off-by: chrismark <chrismarkou92@gmail.com> (cherry picked from commit 1cf2366)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Apr 7, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 7, 2021
…eline * upstream/master: CI: curl seems to be available but where cannot find it (elastic#24965) [mergify] backport automation to 7.x, 7.12 and 7.11 (elastic#24608) Only show deprecation warnings for CN-based verification once (elastic#24948) CI: use ubuntu-20 (elastic#24963) Debug empty root field instead of error (elastic#24966) Kubernetes_secrets provider improvements (elastic#24912)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor leftovers from #24789.
Fetch()if k8s client is not initialised. This can happen if the provider failed to get started withRun()cause api can be unreachable. In such casesFetch()will then panic. We need to skipFetch()in such cases.