-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ec2 metricset to use cloudwatch input as light weight module #25924
Migrate ec2 metricset to use cloudwatch input as light weight module #25924
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
CI failure is also reported in auditbeat. It doesn't look like it's related to this PR: #25956 |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this cleanup! Left some suggestions/comments but overall I'm ok with the change. Let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What does this PR do?
This PR is to migrate
ec2
metricset to use cloudwatch input as light weight module. Two main parts in this PR:In the original
ec2
metricset, we are also making EC2DescribeInstances
API call to get metadata for each EC2 instance. This is added as a part ofcloudwatch
metricset now.You can see under
ec2
metricset, there is only amanifest.yml
file which definescloudwatch
as the input.We need to keep backwards compatibility with metric names so dashboard can still be used.
You can see rename processor is used in
manifest.yml
file underec2
metricset to make sure with this PR we are not introducing breaking changes. Also please check the updateddata.json
file inec2
metricset to see the renaming is effective.Why is it important?
With this change, we no longer need to maintain the common code in both
ec2
metricset andcloudwatch
metricset.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.