Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25924 to 7.x: Migrate ec2 metricset to use cloudwatch input as light weight module #26050

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 1, 2021

Cherry-pick of PR #25924 to 7.x branch. Original message:

What does this PR do?

This PR is to migrate ec2 metricset to use cloudwatch input as light weight module. Two main parts in this PR:

  1. In the original ec2 metricset, we are also making EC2 DescribeInstances API call to get metadata for each EC2 instance. This is added as a part of cloudwatch metricset now.
    You can see under ec2 metricset, there is only a manifest.yml file which defines cloudwatch as the input.

  2. We need to keep backwards compatibility with metric names so dashboard can still be used.
    You can see rename processor is used in manifest.yml file under ec2 metricset to make sure with this PR we are not introducing breaking changes. Also please check the updated data.json file in ec2 metricset to see the renaming is effective.

Why is it important?

With this change, we no longer need to maintain the common code in both ec2 metricset and cloudwatch metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 1, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26050 opened

  • Start Time: 2021-06-01T13:57:59.190+0000

  • Duration: 81 min 35 sec

  • Commit: 36bc6c3

Test stats 🧪

Test Results
Failed 0
Passed 2033
Skipped 192
Total 2225

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2033
Skipped 192
Total 2225

@kaiyan-sheng kaiyan-sheng merged commit 238dc5f into elastic:7.x Jun 1, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_25924_7.x branch June 1, 2021 15:54
@zube zube bot removed the [zube]: Done label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants