Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osquerybeat: Fix the configuration poll interval setting #26739

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Fixes the typo, setting the osquery configuration plugin poll interval correctly.
It's a minor bug, the osquery still functions without this change for typical use cases, but it will use the default refresh interval and will set the extensions timeouts to the larger than expected value.

Why is it important?

Otherwise the configuration poll interval would use a default hardcoded value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

@aleksmaus aleksmaus added bug backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 6, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26739 opened

  • Start Time: 2021-07-06T15:11:27.280+0000

  • Duration: 52 min 51 sec

  • Commit: b7876e3

Test stats 🧪

Test Results
Failed 0
Passed 136
Skipped 0
Total 136

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 136
Skipped 0
Total 136

@aleksmaus aleksmaus merged commit 1e4971f into elastic:master Jul 6, 2021
@aleksmaus aleksmaus deleted the fix/config_poll_interval branch July 6, 2021 16:26
mergify bot pushed a commit that referenced this pull request Jul 6, 2021
* Fix the configuration poll interval setting

* Unit tests

(cherry picked from commit 1e4971f)
mergify bot pushed a commit that referenced this pull request Jul 6, 2021
* Fix the configuration poll interval setting

* Unit tests

(cherry picked from commit 1e4971f)
aleksmaus added a commit that referenced this pull request Jul 6, 2021
…6740)

* Fix the configuration poll interval setting

* Unit tests

(cherry picked from commit 1e4971f)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
aleksmaus added a commit that referenced this pull request Jul 6, 2021
…6741)

* Fix the configuration poll interval setting

* Unit tests

(cherry picked from commit 1e4971f)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Jul 8, 2021
* upstream/master: (430 commits)
  CI: increase timeout (elastic#26764)
  Heartbeat: add datastream fields to synthetics (elastic#26774)
  Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775)
  Remove experimental warning for inputs with variables. (elastic#26762)
  Add latest k8s versions in testing (elastic#26729)
  change type of max_bytes to ByteType (elastic#26699)
  [Elastic Agent] Fix broken enrollment command (elastic#26749)
  Update agent managed manifest to include enrolment token variable (elastic#26756)
  Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737)
  Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754)
  Upgrade PyYAML dependency used for tests (elastic#26746)
  Add agent fleet enrolment k8s manifest (elastic#26566)
  CI: retry the step only (elastic#26736)
  Osquerybeat: Fix the configuration poll interval setting (elastic#26739)
  [Filebeat] Replace copy_from with templated value (elastic#26631)
  Reduce the verbosity of the debug log for monitoring (elastic#26583)
  Add instructions on testing metricbeat kubernetes module (elastic#26643)
  Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704)
  Packaging: linux/armv7 is not supported (elastic#26706)
  Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify bug Team:Asset Mgt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants