Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Remove experimental warning for inputs with variables #26762

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Removes the experimental warning that is printed at the start of Elastic Agent about inputs with variables.

Why is it important?

Being it is now used with the default system package, it does not need to be warned.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 7, 2021
@blakerouse blakerouse self-assigned this Jul 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 7, 2021
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-07T15:40:01.892+0000

  • Duration: 185 min 39 sec

  • Commit: 6f2e3a7

Test stats 🧪

Test Results
Failed 0
Passed 6100
Skipped 14
Total 6114

Trends 🧪

Image of Build Times

Image of Tests

Log output

Expand to view the last 100 lines of log output

[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/artifact/install/tar	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/artifact/install/zip	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/artifact/uninstall	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/artifact/uninstall/hooks	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/basecmd/restart	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/composable/providers/kubernetes	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/composable/providers/kubernetesleaderelection	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/composable/testing	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/config/operations	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/app	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/authority	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/composable	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/monitoring	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/monitoring/config	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/monitoring/noop	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/plugin/process	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/plugin/service	[no test files]
[2021-07-07T16:15:59.571Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/process	[no test files]
[2021-07-07T16:16:00.431Z] ok  	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/server	23.693s	coverage: 79.1% of statements
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/state	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/eql/parser	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/fleetapi/acker	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/fleetapi/acker/noop	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/release	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/reporter/fleet/config	[no test files]
[2021-07-07T16:16:00.431Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/reporter/noop	[no test files]
[2021-07-07T16:16:00.431Z] 
[2021-07-07T16:16:00.431Z] === Skipped
[2021-07-07T16:16:00.431Z] === SKIP: x-pack/elastic-agent/pkg/agent/operation TestConfigurableService (0.00s)
[2021-07-07T16:16:00.431Z]     operator_test.go:392: Flaky test: https://github.com/elastic/beats/issues/23607
[2021-07-07T16:16:00.432Z] 
[2021-07-07T16:16:00.432Z] === SKIP: x-pack/elastic-agent/pkg/core/logger TestLogger (0.00s)
[2021-07-07T16:16:00.432Z]     logger_test.go:10: only checking if test works
[2021-07-07T16:16:00.432Z] 
[2021-07-07T16:16:00.432Z] DONE 874 tests, 2 skipped in 60.708s
[2021-07-07T16:16:01.799Z] >> go test: Unit Test Passed
[2021-07-07T16:16:02.290Z] 
[2021-07-07T16:16:02.290Z] C:\Users\jenkins\workspace\PR-26762-1-ba1c5858-3340-4a98-82c2-e394789740cb\src\github.com\elastic\beats>FOR / %d IN ("ve") DO @IF EXIST "%d" rmdir /s /q "%d" 
[2021-07-07T16:16:02.641Z] 
[2021-07-07T16:16:02.641Z] C:\Users\jenkins\workspace\PR-26762-1-ba1c5858-3340-4a98-82c2-e394789740cb\src\github.com\elastic\beats>python .ci/scripts/pre_archive_test.py 
[2021-07-07T16:16:03.203Z] Copy .\x-pack\elastic-agent\build into build\x-pack\elastic-agent\build
[2021-07-07T16:16:03.231Z] Running in C:\Users\jenkins\workspace\PR-26762-1-ba1c5858-3340-4a98-82c2-e394789740cb\src\github.com\elastic\beats\build
[2021-07-07T16:16:03.277Z] Recording test results
[2021-07-07T16:16:04.201Z] [Checks API] No suitable checks publisher found.
[2021-07-07T16:16:04.651Z] 
[2021-07-07T16:16:04.651Z] C:\Users\jenkins\workspace\PR-26762-1-ba1c5858-3340-4a98-82c2-e394789740cb\src\github.com\elastic\beats>go clean -modcache 
[2021-07-07T16:16:06.142Z] ok  	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/scheduler	10.584s	coverage: 100.0% of statements
[2021-07-07T16:16:16.126Z] ok  	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/server	26.580s	coverage: 80.2% of statements
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/core/state	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/eql/parser	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/fleetapi/acker	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/fleetapi/acker/noop	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/release	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/reporter/fleet/config	[no test files]
[2021-07-07T16:16:16.126Z] ?   	github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/reporter/noop	[no test files]
[2021-07-07T16:16:16.126Z] 
[2021-07-07T16:16:16.126Z] === Skipped
[2021-07-07T16:16:16.126Z] === SKIP: x-pack/elastic-agent/pkg/agent/operation TestConfigurableService (0.00s)
[2021-07-07T16:16:16.126Z]     operator_test.go:392: Flaky test: https://github.com/elastic/beats/issues/23607
[2021-07-07T16:16:16.126Z] 
[2021-07-07T16:16:16.126Z] === SKIP: x-pack/elastic-agent/pkg/core/logger TestLogger (0.00s)
[2021-07-07T16:16:16.126Z]     logger_test.go:10: only checking if test works
[2021-07-07T16:16:16.126Z] 
[2021-07-07T16:16:16.126Z] DONE 874 tests, 2 skipped in 75.177s
[2021-07-07T16:16:17.503Z] >> go test: Unit Test Passed
[2021-07-07T16:16:17.991Z] 
[2021-07-07T16:16:17.991Z] C:\Users\jenkins\workspace\PR-26762-1-d161ff3a-7d56-4695-9356-cf426e8dd03f\src\github.com\elastic\beats>FOR / %d IN ("ve") DO @IF EXIST "%d" rmdir /s /q "%d" 
[2021-07-07T16:16:18.567Z] 
[2021-07-07T16:16:18.567Z] C:\Users\jenkins\workspace\PR-26762-1-d161ff3a-7d56-4695-9356-cf426e8dd03f\src\github.com\elastic\beats>python .ci/scripts/pre_archive_test.py 
[2021-07-07T16:16:19.135Z] Copy .\x-pack\elastic-agent\build into build\x-pack\elastic-agent\build
[2021-07-07T16:16:19.163Z] Running in C:\Users\jenkins\workspace\PR-26762-1-d161ff3a-7d56-4695-9356-cf426e8dd03f\src\github.com\elastic\beats\build
[2021-07-07T16:16:19.211Z] Recording test results
[2021-07-07T16:16:19.948Z] [Checks API] No suitable checks publisher found.
[2021-07-07T16:16:20.412Z] 
[2021-07-07T16:16:20.412Z] C:\Users\jenkins\workspace\PR-26762-1-d161ff3a-7d56-4695-9356-cf426e8dd03f\src\github.com\elastic\beats>go clean -modcache 
[2021-07-07T16:16:53.033Z] + gsutil --version
[2021-07-07T16:16:54.452Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-07-07T16:16:54.798Z] + gcloud auth activate-service-account --key-file ****
[2021-07-07T16:16:55.366Z] Activated service account credentials for: [beats-ci-gcs-plugin@elastic-ci-prod.iam.gserviceaccount.com]
[2021-07-07T16:16:55.984Z] + gsutil -m -q cp -a public-read eC1wYWNrL2VsYXN0aWMtYWdlbnQtd2luZG93cy03LXdpbmRvd3MtNzZmMmUzYTcyODJhMGEzZWNiNzkyOGM0ZTEyMTBkYTAxNzRkNTY5Y2M gs://beats-ci-temp/ci/cache/
[2021-07-07T16:17:09.217Z] + gsutil --version
[2021-07-07T16:17:10.636Z] Masking supported pattern matches of $FILE_CREDENTIAL
[2021-07-07T16:17:10.978Z] + gcloud auth activate-service-account --key-file ****
[2021-07-07T16:17:11.549Z] Activated service account credentials for: [beats-ci-gcs-plugin@elastic-ci-prod.iam.gserviceaccount.com]
[2021-07-07T16:17:12.175Z] + gsutil -m -q cp -a public-read eC1wYWNrL2VsYXN0aWMtYWdlbnQtd2luZG93cy0yMDE2LXdpbmRvd3MtMjAxNjZmMmUzYTcyODJhMGEzZWNiNzkyOGM0ZTEyMTBkYTAxNzRkNTY5Y2M gs://beats-ci-temp/ci/cache/
[2021-07-07T18:44:12.242Z] Cancelling nested steps due to timeout
[2021-07-07T18:44:12.247Z] Sending interrupt signal to process
[2021-07-07T18:44:12.676Z] Sending interrupt signal to process
[2021-07-07T18:44:32.248Z] After 20s process did not stop
[2021-07-07T18:44:32.320Z] Sleeping for 5 sec
[2021-07-07T18:44:38.897Z] Failed in branch x-pack/elastic-agent-windows-10-windows-10
[2021-07-07T18:44:39.171Z] Stage "Packaging" skipped due to earlier failure(s)
[2021-07-07T18:44:39.254Z] Stage "Packaging-Pipeline" skipped due to earlier failure(s)
[2021-07-07T18:44:39.365Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-26762/src/github.com/elastic/beats
[2021-07-07T18:44:40.148Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-26762
[2021-07-07T18:44:40.250Z] [INFO] getVaultSecret: Getting secrets
[2021-07-07T18:44:40.296Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-07T18:44:41.317Z] + chmod 755 generate-build-data.sh
[2021-07-07T18:44:41.318Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26762/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26762/runs/1 ABORTED 11079153
[2021-07-07T18:44:41.318Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-26762/runs/1/steps/?limit=10000 -o steps-info.json

@blakerouse blakerouse merged commit c0b75e9 into elastic:master Jul 7, 2021
@blakerouse blakerouse deleted the agent-remove-warn-dyn-inputs branch July 7, 2021 18:52
mergify bot pushed a commit that referenced this pull request Jul 7, 2021
mergify bot pushed a commit that referenced this pull request Jul 7, 2021
blakerouse added a commit that referenced this pull request Jul 8, 2021
(cherry picked from commit c0b75e9)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
blakerouse added a commit that referenced this pull request Jul 8, 2021
(cherry picked from commit c0b75e9)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Jul 8, 2021
* upstream/master: (430 commits)
  CI: increase timeout (elastic#26764)
  Heartbeat: add datastream fields to synthetics (elastic#26774)
  Osquerybeat: Change the query timeout from 3 secs to 60 secs (elastic#26775)
  Remove experimental warning for inputs with variables. (elastic#26762)
  Add latest k8s versions in testing (elastic#26729)
  change type of max_bytes to ByteType (elastic#26699)
  [Elastic Agent] Fix broken enrollment command (elastic#26749)
  Update agent managed manifest to include enrolment token variable (elastic#26756)
  Filebeat: Ensure module pipelines compatibility with previous versions of Elasticsearch (elastic#26737)
  Forward port changelog for 7.13.3 (elastic#26731) to master (elastic#26754)
  Upgrade PyYAML dependency used for tests (elastic#26746)
  Add agent fleet enrolment k8s manifest (elastic#26566)
  CI: retry the step only (elastic#26736)
  Osquerybeat: Fix the configuration poll interval setting (elastic#26739)
  [Filebeat] Replace copy_from with templated value (elastic#26631)
  Reduce the verbosity of the debug log for monitoring (elastic#26583)
  Add instructions on testing metricbeat kubernetes module (elastic#26643)
  Revert "[CI] fight the flakiness with some retry option in the CI only for the Pull Requests (elastic#26617)" (elastic#26704)
  Packaging: linux/armv7 is not supported (elastic#26706)
  Cyberarkpas: Link to official docs on how to setup TLS (elastic#26614)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants