Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite: change github comments #38173

Closed
wants to merge 1 commit into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 4, 2024

Proposed commit message

  • WHAT: Simplify the GitHub comment for running the Buildkite pipeline.
  • WHY: This pipeline is not currently used, and it was created as a placeholder. This will help with PoC: use pipeline generator #38162 temporarily, then it could be changed again.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

I used https://regex101.com/ for verifying the regex:

image

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2024
@botelastic
Copy link

botelastic bot commented Mar 4, 2024

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned v1v Mar 4, 2024
Copy link
Contributor

mergify bot commented Mar 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@v1v v1v marked this pull request as ready for review March 4, 2024 16:29
@v1v v1v requested a review from a team as a code owner March 4, 2024 16:29
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 11 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@v1v v1v enabled auto-merge (squash) March 5, 2024 08:54
@v1v v1v mentioned this pull request Mar 7, 2024
13 tasks
@rowlandgeoff
Copy link
Contributor

@alexsapran This older open PR looks very similar to your fix from #38487

@v1v
Copy link
Member Author

v1v commented Mar 21, 2024

@alexsapran This older open PR looks very similar to your fix from #38487

Indeed, #38487 might have some side effects while Jenkins is still the CI.

This PR was intended to leverage the existing proposal in #38162 without running twice (builds in Jenkins and Buildkite) during the migration. That's the reason I used the building prefix rather than /test

@alexsapran
Copy link
Contributor

What type of side effects you are thinking of? other than the fact that it will trigger both?

It's something that I wanted to have, so I can test that both implementations are doing what we want them to do, this is how I discovered for example an issue with how we select some pipeline steps, by checking the Jenkins and Buildkite steps.

@v1v
Copy link
Member Author

v1v commented Mar 21, 2024

What type of side effects you are thinking of? other than the fact that it will trigger both?

That's the only thing.

It's something that I wanted to have, so I can test that both implementations are doing what we want them to do, this is how I discovered for example an issue with how we select some pipeline steps, by checking the Jenkins and Buildkite steps.

Then forget please what I said, I didn't have that context. Sorry for the noise 🙏

@v1v
Copy link
Member Author

v1v commented Mar 21, 2024

I'll close this now as duplicates the other one

@v1v v1v closed this Mar 21, 2024
auto-merge was automatically disabled March 21, 2024 10:01

Pull request was closed

@alexsapran
Copy link
Contributor

Then forget please what I said, I didn't have that context. Sorry for the noise 🙏

Better safe than sorry, thanks for keeping an eye and for asking questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants