Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the proper comment to trigger the central pipeline #38487

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Set the proper comment to trigger the central pipeline #38487

merged 2 commits into from
Mar 20, 2024

Conversation

alexsapran
Copy link
Contributor

@alexsapran alexsapran commented Mar 20, 2024 •
edited
Loading

Proposed commit message

The new main dynamic pipeline parses the comment and outputs what steps are needed, so we don't need the buildkite-pr-bot to control that anymore.

What we would like to do is be able to trigger the buildkite/beats pipeline with any comment starting with /test .... so that the generate step would parse it and output the appropriate pipeline steps.

Some examples

/test filebeat
/test filebeat mandatory unitTest
/test filebeat extended unitTest-arm
...

Related: https://github.com/elastic/ingest-dev/issues/2992

@alexsapran
Set the proper comment to trigger the central pipeline
e9e1f33 
The new main dynamic pipeline parses the comment and output what steps
are needed, so we dont really need the buildkite-pr-bot to controll
that anymore.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
@alexsapran alexsapran self-assigned this Mar 20, 2024
@alexsapran alexsapran requested a review from a team as a code owner March 20, 2024 15:35
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @alexsapran? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@alexsapran alexsapran added the backport-v8.13.0 Automated backport with mergify label Mar 20, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 20, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 15 min 6 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dliappis
dliappis approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment, but it's harmless as is, so need for another review cycle.

.buildkite/pull-requests.json Outdated Show resolved Hide resolved
@alexsapran
Remove group
ef4086f 
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
@alexsapran alexsapran enabled auto-merge (squash) March 20, 2024 16:03
dliappis
dliappis approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsapran alexsapran merged commit 16f8d09 into elastic:main Mar 20, 2024
30 of 35 checks passed
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
@alexsapran @mergify
Set the proper comment to trigger the central pipeline (#38487)
8d6350d 
The new main dynamic pipeline parses the comment and outputs what steps
are needed, so we don't need the buildkite-pr-bot to control
that anymore.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit 16f8d09)
@mergify mergify bot mentioned this pull request Mar 20, 2024
Merged
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 20, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @alexsapran

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @alexsapran

@rowlandgeoff rowlandgeoff mentioned this pull request Mar 21, 2024
Closed
6 tasks
alexsapran added a commit that referenced this pull request Mar 21, 2024
@mergify @alexsapran
[8.13](backport #38487) Set the proper comment to trigger the central…
ff83668 
… pipeline (#38489)

The new main dynamic pipeline parses the comment and outputs what steps
are needed, so we don't need the buildkite-pr-bot to control
that anymore.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit 16f8d09)

Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@alexsapran alexsapran

Labels
backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsapran @elasticmachine @dliappis