Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditbeat TestExeObjParser - fix errors.Is argument order #38606

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 26, 2024

Proposed commit message

The arguments to errors.Is are in the wrong order so the check is not working as designed and the test was never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: #38211

How to test this PR locally

cd auditbeat/module/file_integrity
rm ./testdata/garble_macho_executable
CI=true go test -run TestExeObjParser -v .

The arguments to errors.Is are in the wrong order so the check
is not working as designed and test is never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: elastic#38211
@andrewkroh andrewkroh added bug Auditbeat flaky-test Unstable or unreliable test cases. labels Mar 26, 2024
@andrewkroh andrewkroh requested a review from a team as a code owner March 26, 2024 00:39
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 26, 2024
@botelastic
Copy link

botelastic bot commented Mar 26, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Mar 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 26, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 48 min 0 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the backport-v8.13.0 Automated backport with mergify label Mar 26, 2024
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh enabled auto-merge (squash) March 26, 2024 18:39
@andrewkroh andrewkroh merged commit cd89cc4 into elastic:main Mar 26, 2024
45 of 49 checks passed
mergify bot pushed a commit that referenced this pull request Mar 26, 2024
The arguments to errors.Is are in the wrong order so the check
is not working as designed and test is never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: #38211
(cherry picked from commit cd89cc4)
andrewkroh added a commit that referenced this pull request Mar 26, 2024
…38630)

The arguments to errors.Is are in the wrong order so the check
is not working as designed and test is never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: #38211
(cherry picked from commit cd89cc4)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat backport-v8.13.0 Automated backport with mergify bug flaky-test Unstable or unreliable test cases. needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants