Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #38606) auditbeat TestExeObjParser - fix errors.Is argument order #38630

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2024

Proposed commit message

The arguments to errors.Is are in the wrong order so the check is not working as designed and the test was never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: #38211

How to test this PR locally

cd auditbeat/module/file_integrity
rm ./testdata/garble_macho_executable
CI=true go test -run TestExeObjParser -v .

This is an automatic backport of pull request #38606 done by [Mergify](https://mergify.com).

The arguments to errors.Is are in the wrong order so the check
is not working as designed and test is never skipped.

Also stop the test after exeObjParser.Parse fails.

Relates: #38211
(cherry picked from commit cd89cc4)
@mergify mergify bot requested a review from a team as a code owner March 26, 2024 18:42
@mergify mergify bot added the backport label Mar 26, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 26, 2024
@botelastic
Copy link

botelastic bot commented Mar 26, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-26T18:42:26.465+0000

  • Duration: 46 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 1019
Skipped 132
Total 1151

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh merged commit 2793657 into 8.13 Mar 26, 2024
24 checks passed
@andrewkroh andrewkroh deleted the mergify/bp/8.13/pr-38606 branch March 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants