Migrate fileset to ECS #8879
Merged
Migrate fileset to ECS #8879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
reviewed
Nov 5, 2018
ruflin
force-pushed
the
fileset-ecs-migration
branch
2 times, most recently
from
12eadf8
to
cf4d448
Compare
ruflin
added
review
and removed
in progress
The following fields were migrated to ECS: * fileset.name -> event.dataset * fileset.module -> event.module Changes: * Update generated files * Update tests * Update changelog * Update migration file
ruflin
force-pushed
the
fileset-ecs-migration
branch
from
cf4d448
to
8db5255
Compare
|
Test failure is not related. |
ph
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
@ruflin I presume we will make the changes on the dashboard in a followup PR using the ecs migration yaml file?
x-pack/filebeat/module/suricata/_meta/kibana/6/dashboard/Filebeat-Suricata-Overview.json
448: "key": "fileset.module",
459: "fileset.module": {
694: "key": "fileset.module",
705: "fileset.module": {
``
| @@ -11,7 +11,17 @@ | |||
| # # Copy to is useful for fields where multiple fields map to the same ECS field | |||
| # copy_to: true-if-field-should-be-copied-to-target-in-6x | |||
|
|
|||
| @@ -176,7 +176,7 @@ def _test_expected_events(self, test_file, objects): | |||
| clean_keys(obj) | |||
|
|
|||
| # Remove timestamp for comparison where timestamp is not part of the log line | |||
| if obj["fileset.module"] == "icinga" and obj["fileset.name"] == "startup": | |||
| if obj["event.module"] == "icinga" and obj["event.dataset"] == "startup": | |||
There was a problem hiding this comment.
I've seen that hack too, I think we could add a test.json inside the module to configure the assertions, to do in another PR of course.
There was a problem hiding this comment.
yes, would be nice to do it differently.
|
@ph For the dashboards: Yes plan is to hopefully be able to do it in an automated way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fields were migrated to ECS:
Changes: