Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suricata dashboards #8953

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix suricata dashboards #8953

merged 1 commit into from
Nov 7, 2018

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Nov 6, 2018

Restore broken panelsJSON from the PR #8675.

I tested by running the ./libbeat/scripts/unpack_dashboards.py script, copying the file to the Filebeat distribution, and running filebeat setup.

Fixes #8952.

Restore broken panelsJSON from the PR elastic#8675.
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working, thanks for your fix

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the error anymore. Tested with

git checkout -b tsg-fix_suricata_dashboards master
git pull git://github.com/tsg/beats.git fix_suricata_dashboards
cd x-pack/filebeat
mage clean update build
./filebeat setup --dashboards -E setup.dashboards.directory=build/kibana -e -d "*"

@andrewkroh
Copy link
Member

This would be good for 6.5. But in master there were changes in #8879 that are now missing. The saved searches reference fileset.module which has been renamed to event.module in master.

@ruflin
Copy link
Member

ruflin commented Nov 7, 2018

@andrewkroh Dashboards were not renamed yet in the ECS changes as I hope to be able to automate these. Or did I misunderstand your comment?

@tsg
Copy link
Contributor Author

tsg commented Nov 7, 2018

My first priority is to fix 6.5, so I'm going to merge and backport this. I'm not sure if master is affected or not, since this is just "linking" the widgets in the dashboard.

@tsg tsg merged commit 4d718fa into elastic:master Nov 7, 2018
@tsg tsg added the v6.5.0 label Nov 7, 2018
tsg added a commit to tsg/beats that referenced this pull request Nov 7, 2018
Restore broken panelsJSON from the PR elastic#8675.

(cherry picked from commit 4d718fa)
tsg added a commit to tsg/beats that referenced this pull request Nov 7, 2018
Restore broken panelsJSON from the PR elastic#8675.

(cherry picked from commit 4d718fa)
@tsg tsg added the v6.6.0 label Nov 7, 2018
tsg added a commit that referenced this pull request Nov 7, 2018
Restore broken panelsJSON from the PR #8675.

(cherry picked from commit 4d718fa)
tsg added a commit that referenced this pull request Nov 23, 2018
Restore broken panelsJSON from the PR #8675.

(cherry picked from commit 4d718fa)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Restore broken panelsJSON from the PR elastic#8675.

(cherry picked from commit db86db3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants