Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kind() funcs #1831

Closed
anyasabo opened this issue Oct 1, 2019 · 3 comments · Fixed by #1837
Closed

Remove Kind() funcs #1831

anyasabo opened this issue Oct 1, 2019 · 3 comments · Fixed by #1837
Labels
>refactoring

Comments

@anyasabo
Copy link
Contributor

anyasabo commented Oct 1, 2019

Related to #338

Since we upgraded to kubebuilder v2 I think we can remove the extra Kind funcs on our CR types that we added to work around the behavior.

Upstream issue: kubernetes-sigs/controller-runtime#406
@racevedoo
Copy link
Contributor

Hi @anyasabo, can I take this? Seems pretty straightforward

@anyasabo
Copy link
Contributor Author

anyasabo commented Oct 1, 2019

Would definitely welcome a PR @racevedoo :)

racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
da7ca53
@racevedoo
Copy link
Contributor

PR opened #1837

racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
b41489a
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
844c25e
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
515fb1d
@racevedoo racevedoo mentioned this issue Oct 1, 2019
Merged
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 1, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
b319dd0
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 2, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
ba72757
racevedoo added a commit to racevedoo/cloud-on-k8s that referenced this issue Oct 2, 2019
@racevedoo
remove extra Kind() funcs for cr types (elastic#1831)
85389c6
anyasabo pushed a commit that referenced this issue Oct 3, 2019
@racevedoo @anyasabo
remove extra Kind() funcs for cr types (#1831) (#1837)
4976cb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra Kind() funcs for cr types racevedoo/cloud-on-k8s
2 participants
@anyasabo @racevedoo