-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra Kind() funcs for cr types #1837
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
b41489a
to
844c25e
Compare
LGTM, if you can fix up the merge issues from a PR that snuck in before this one we should be good |
844c25e
to
515fb1d
Compare
conflicts fixed |
515fb1d
to
b319dd0
Compare
jenkins test this please |
b319dd0
to
ba72757
Compare
One last reference I just noticed: there is also a TODO in |
ba72757
to
85389c6
Compare
@anyasabo removed the TODO. All the places where |
jenkins test this please |
Removing it sounds good to me, I am not sure that changing it back to consuming a |
I guess there's no need for it to know about the whole |
thanks @racevedoo ! |
This PR removes a Kind() method used to workaround kubernetes-sigs/controller-runtime#406. It is no longer needed.
Fixes #1831