Update module sigs.k8s.io/controller-runtime to v0.15.0 #6847
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
The package Also, func EnqueueRequestForOwner(scheme *runtime.Scheme, mapper meta.RESTMapper, ownerType client.Object, opts ...OwnerOption) EventHandler {Support to add dynamically watchers has been added:
But not to remove them:
Hence, we'll update our own custom implementation for now. |
thbkrkr
force-pushed
the
renovate/sigs.k8s.io-controller-runtime-0.x
branch
from
5003f3b
to
e562b22
Compare
…y opts.Cache.Namespaces
thbkrkr
force-pushed
the
renovate/sigs.k8s.io-controller-runtime-0.x
branch
from
e562b22
to
7053253
Compare
| WithObjects(initObjs...). | ||
| WithStatusSubresource(initObjs...). | ||
| WithScheme(clientgoscheme.Scheme). | ||
| Build() |
There was a problem hiding this comment.
It's now important to call WithStatusSubresource() explicitly in NewFakeClient().
| Conditions: commonv1alpha1.Conditions{commonv1alpha1.Condition{Type: "ReconciliationComplete", Status: "True"}}, | ||
| InProgressOperations: noInProgressOperations, | ||
| }, | ||
| ).BuildAndCopy(), |
There was a problem hiding this comment.
There is no more a 409/resource conflict in this unit test and the status resource is well updated.
|
Need to spend a bit more time tomorrow but so far it looks really good and uncontroversial to me! |
| log.Info("Polling for the webhook certificate to be available", "path", keyPath) | ||
| err := wait.PollImmediate(interval, timeout, func() (bool, error) { | ||
| //nolint:staticcheck | ||
| err := wait.PollImmediateWithContext(ctx, interval, timeout, func(_ context.Context) (bool, error) { |
There was a problem hiding this comment.
PollImmediate is deprecated but there was a mistake and the new functions are also deprecated, hence the nolint:staticcheck to prevent the go linter from complaining.
|
@elasticmachine run elasticsearch-ci/docs |
This PR updates
sigs.k8s.io/controller-runtimefromv0.14.6tov0.15.0and ECK due to breaking changes brought by this new version.Release Notes
kubernetes-sigs/controller-runtime
v0.15.0Compare Source
Controller Runtime v0.15
Changes since v0.14.5
*http.Clientconfigurable and use/share the same client by default (#2122)client/apiutil.NewDynamicRESTMappersignature has changed and now requires an*http.Clientas parameter.cluster.Clusterinterface requiresGetHTTPClient()method which must return an already configured, non-nil,*http.Clientfor the Cluster. When usingcluster.Newto create Clusters, the client is created internally if not specified as anOptionsfield.cluster.Options.MapperProviderfield now requires a*rest.Configand*http.Client.config/v1alpha1types (#2149, #2200)Manager.Optionsdirectly.pkg/injecthas been removed, this package contained long deprecated injection functions (likeInjectScheme,InjectLogger,InjectConfig,InjectClient,InjectCache, etc.).Managerto structs or interfaces that need them.builderpackage capabilities and general UX (#2135)builder.Builder.Watchessignature has changed, it now takes aclient.Objectinstead of asource.Sourceas first argument.source.Source, useWatchesRawSource.builder.Builder.WatchesMetadatahas been added to simplify watchingPartialObjectMetadataobjects.cache.Options.Namespacehas been removed in favor ofcache.Options.Namespaces, a slice.cache.Options.Resynchas been renamed toSyncPeriod.cache.Options.DefaultSelectorhas been removed and split in two fields:cache.Options.DefaultLabelSelectorcache.Options.DefaultFieldSelectorcache.Options.DefaultTransformwas added to provide a global transform function.cache.Options.UnsafeDisableDeepCopywas added to provide a global toggle to disable DeepCopy of the objects from the cache before returning them to clients.[..]ByObjectfield have been refactored:cache.Options.SelectorsByObjecthas been removed, usecache.Options.ByObject[Object].Fieldandcache.Options.ByObject[Object].Labelcache.Options.UnsafeDisableDeepCopyByObjecthas been removed, usecache.Options.ByObject[Object].UnsafeDisableDeepCopy.cache.Options.TransformByObjecthas been removed, usecache.Options.ByObject[Object].Transform.cache.ObjectAllhas been removed. This type was previously used to set selectors or transformation functions for every object, use the newly introduced default global options instead.handler.EventHandlerandhandler.Funcsinterfaces requirecontext.Contextas the first parameter for every method.handler.MapFuncsignature has changed and now requires acontext.Context.client.Clientinterface now requires and exposes these helper functions:GroupVersionKindFor(Object)which returns theschema.GroupVersionKindfor the object.IsObjectNamespaced(Object)which returnstrueif the object's GroupVersionKind is namespaced, orfalsefor global ones.client.New(#2150)client.NewDelegatingClientconstructor andclient.NewDelegatingClientInputstruct have been removed.client.Newand setclient.Options.Cacheto customize the client's caching behavior.cluster.NewClientFunchas been moved toclient.NewClientFunc.cluster.ClientOptionshas been removed.cluster.DefaultNewClienthas been removed.cluster.ClientBuilderWithOptionshas been removed.manager.Options.Cacheis now the preferred way to customize the cache options for the manager.manager.Options.NewCache, which has now been marked as a low level primitive.manager.Options.Clientis now the preferred way to customize the client options for the manager.manager.Options.NewClient, which has now been marked as a low level primitive.manager.Options.SyncPeriodhas been deprecated in favor ofmanager.Options.Cache.SyncPeriod.manager.Options.Namespacehas been deprecated in favor ofmanager.Options.Cache.Namespaces.manager.Options.DryRunClienthas been deprecated in favor ofmanager.Options.Client.DryRun.manager.Options.ClientDisableCacheForhas been deprecated in favor ofmanager.Options.Client.Cache.DisableCacheFor.manager.WebhookServerinstead.manager.Options.Portmanager.Options.Hostmanager.Options.CertDirmanager.Options.TLSOptscache.BuilderWithOptions(#2300)webhook/conversion, removewebhook/admission.GetDecoder()(#2144)webhook/admission/Webhook.GetDecoder()method has been removed, it was unused before and relied on runtime dependency injection.webhook/conversion.Webhookstruct has been un-exported. Users should usewebhook/conversion.NewWebhookHandlerinstead.pkg/webhook/admission:Result.Messageinstead ofResult.Reason(#1539)ValidatorandCustomValidatorinterfaces have been modified to allow returning warnings (#2014)WithStatusSubresourceoption and pre-populating it withall in-tree resources that have a status subresource
UpdateandPatchmethods now don't change the status for any suchresource anymore
UpdateandPatchmethods now only change the statusfor any such resource
rest_client_request_latency_secondsrest_client_request_duration_secondsrest_client_request_size_bytesrest_client_response_size_byteswebhook.Serverstruct is now an interfacewebhook.NewServercan be used to pass in and customize the default serverlog.DelegatingLogSinkhas been unexported, this logger should never be used on its own, and it's only meant to be used within controller-runtime initialization process.pkg/logpackage was imported, there was aninitfunction that spawned a goroutine, which set a null logger after 30 seconds. Now this logic has been removed, and instead incorporated into the delegating logger private implementation.WithCustomMapper,WithExperimentalLazyMapper,WithLazyDiscovery,WithLimiter.DynamicRESTMapperOptiontype has been removed.✨ New Features
Manager.Options.PprofBindAddress.reconcile.TerminalError(...)(#2325)controller_runtime_terminal_reconcile_errors_totalmetric is incremented.🐛 Bug Fixes
🌱 Others
NewDynamicRESTMapper(#2178)🌱 Dependencies
📖 Additionally, there have been 4 contributions to our documentation and book. (#2203, #2201, #2162, #2170)
Thanks to all our contributors! 😊
Initially generated by Mend Renovate. View repository job log here.