Bad deprecation notices in 0.27.1 ?! Referenced PollWithContextTimeout does not exist ?!

[andreas-kupries]

After a bump to 0.27.1 the golang-ci-linter told me

wait.PollImmediate is deprecated: This method does not return errors from context, use PollWithContextTimeout

Looking at the 0.27.1 documentation I find PollWithContext, but no PollWithContextTimeout.

https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait#PollWithContext
https://pkg.go.dev/search?q=PollWithContextTimeout&m=symbol

Grepping the package sources I find that PollWithContextTimeout is only referenced in the deprecation notices in the comments. No implementation is found. See below.

The nearest similar function looks to be https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait#PollUntilContextTimeout

% grep -rn PollWithContextTimeout .
./k8s.io/apimachinery@v0.27.1/pkg/util/wait/poll.go:44:// inline usage. All other behavior is identical to PollWithContextTimeout.
./k8s.io/apimachinery@v0.27.1/pkg/util/wait/poll.go:62:// Deprecated: This method does not return errors from context, use PollWithContextTimeout.
./k8s.io/apimachinery@v0.27.1/pkg/util/wait/poll.go:81:// Deprecated: This method does not return errors from context, use PollWithContextTimeout.
./k8s.io/apimachinery@v0.27.1/pkg/util/wait/poll.go:153:// Deprecated: This method does not return errors from context, use PollWithContextTimeout.
./k8s.io/apimachinery@v0.27.1/pkg/util/wait/poll.go:171:// Deprecated: This method does not return errors from context, use PollWithContextTimeout.

What is the actual method to use instead of the deprecated ones ?

[laverya]

See also kubernetes/kubernetes#116712

[damdo]

Fixed by https://github.com/kubernetes/kubernetes/pull/117143/files
I think we can close this.

[iblancasa]

I can see this problem in v0.27.3:

SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.

[till]

WWIW, can also confirm on 0.27.5.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[till]

I understand that no one has time, but can no one look into this and see if this is a bug?

[kaovilai]

can no one look

yep no one looked :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.