-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch logstash to asciidoctor #1005
Conversation
Switches the core of the docs build from the no-longer-maintained AsciiDoc to the actively developed Asciidoctor.
I'm going to use this PR to coordinate any remaining activities required to convert Logstash's docs to asciidoctor. I'm working on and off on summarizing a diff of the logstash reference built with asciidoctor but it is slow going. For now have a preview. One thing that seems pretty common is for two examples to be joined together like this. So far I've only seen those go up to 5.6 or so but I'm starting at older versions and going forward and might discover all kinds of fun as time goes on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome progress, Nik. Please keep me posted on what you need from me as you move forward.
Manual summary of 467347 line diff Do before switching to Asciidoctor:
Do shortly after switching to Asciidoctor:
Do eventually:
Done:
Ignored:
|
Many ids changed. We probably don't care about these to be honest because they aren't generally for the most modern version of the pages. I hate breaking old anchors but it isn't too bad because folks will still end up on the right page, just on the right part of the page. Here is the list anyway:
|
I also pushed b9c1eee to fix up the alias. |
Switches the core of the docs build from the no-longer-maintained
AsciiDoc to the actively developed Asciidoctor.