Docs: Different edit_me overrides for asciidoctor #10989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added support for setting `edit_url` to override the url in the `edit_me` style links used by asciidoctor. This "override" doesn't properly emulate asciidoc when you set the `edit_url` to an empty string with lines like: ``` :edit_url: ``` While we *could* make it work the same way it is a conceptual mismatch with the whole "override" mechanics. Thus I propose we change logstash to use conditional evaluation in those lines. This does the right thing for AsciiDoc and for Asciidoctor. Once we switch to the build to Asciidoctor we can drop the conditions in a cleanup change.
|
@elasticmachine, rerun tests |
|
I don't think this one is needed any more. At least, all of the lines it was targeting have changed since I opened it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for setting
edit_urlto override the url in theedit_mestyle links used by asciidoctor. This "override" doesn'tproperly emulate asciidoc when you set the
edit_urlto an empty stringwith lines like:
While we could make it work the same way it is a conceptual mismatch
with the whole "override" mechanics. Thus I propose we change logstash
to use conditional evaluation in those lines. This does the right thing
for AsciiDoc and for Asciidoctor. Once we switch to the build to
Asciidoctor we can drop the conditions in a cleanup change.