added layout #145

dgempiuc · 2021-09-30T13:41:33Z

layout field added and encode method modified by using the layout while adding the messages to the log file.

cla-checker-service · 2021-09-30T13:41:36Z

💚 CLA has been signed

apmmachine · 2021-09-30T13:45:18Z

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-21T10:31:22.417+0000
Duration: 3 min 0 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/ecs-logging-java.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/dgempiuc return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

fapena-galileo · 2021-12-22T22:01:10Z

Any news on this PR? It would be very useful to be able to configure the layout to customize the message.

…ecs-encoder

eyalkoren

@dgempiuc this looks like a reasonable functionality addition, thanks.
Note that we won't be able to merge the PR without you signing the Contributor Agreement with your GitHub email.

@felixbarny any reason you see for not adding it?

eyalkoren · 2022-04-27T13:35:45Z

logback-ecs-encoder/src/main/java/co/elastic/logging/logback/EcsEncoder.java

@@ -54,6 +55,7 @@ public class EcsEncoder extends EncoderBase<ILoggingEvent> {
    private boolean includeOrigin;
    private final List<AdditionalField> additionalFields = new ArrayList<AdditionalField>();
    private OutputStream os;
+    protected Layout<ILoggingEvent> layout;


Suggested change

protected Layout<ILoggingEvent> layout;

protected Layout<ILoggingEvent> messageLayout;

eyalkoren · 2022-04-27T13:36:15Z

logback-ecs-encoder/src/main/java/co/elastic/logging/logback/EcsEncoder.java

+        if(layout == null) {
+            EcsJsonSerializer.serializeFormattedMessage(builder, event.getFormattedMessage());
+        } else {
+            EcsJsonSerializer.serializeFormattedMessage(builder, this.layout.doLayout(event));


Suggested change

EcsJsonSerializer.serializeFormattedMessage(builder, this.layout.doLayout(event));

EcsJsonSerializer.serializeFormattedMessage(builder, this.messageLayout.doLayout(event));

eyalkoren · 2022-04-27T13:36:45Z

logback-ecs-encoder/src/main/java/co/elastic/logging/logback/EcsEncoder.java

+    public Layout<ILoggingEvent> getLayout() {
+        return this.layout;
+    }
+


Suggested change

public Layout<ILoggingEvent> getLayout() {

return this.layout;

}

No need for a getter

eyalkoren · 2022-04-27T13:38:17Z

logback-ecs-encoder/src/main/java/co/elastic/logging/logback/EcsEncoder.java

+    public void setLayout(Layout<ILoggingEvent> layout) {
+        this.layout = layout;
+    }


Suggested change

public void setLayout(Layout<ILoggingEvent> layout) {

this.layout = layout;

}

public void setMessageLayout(Layout<ILoggingEvent> messageLayout) {

this.messageLayout = messageLayout;

}

Add a javadoc saying this Layout will be applied specifically to format the message field based on the logging event.

felixbarny · 2022-04-27T14:11:50Z

@felixbarny any reason you see for not adding it?

No objections but it would be interesting to know about the use case this solves. Why would you want to use a layout within the message field?

rdifrango · 2022-09-07T19:35:35Z

@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

felixbarny · 2022-09-09T08:07:22Z

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

SGTM. But please be sure to take his commits as the foundation so that he still appears as a co-author of your PR.

maxiking445 · 2023-04-05T13:33:26Z

@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

Any news here? @rdifrango

rdifrango · 2023-04-18T17:48:39Z

@maxiking445 Unfortunately, I haven't had time to get back to it...I had it staged and started the proposed changes but haven't yet finished them :(

rdifrango · 2023-11-29T18:36:41Z

@maxiking445 I'm working through the process now to contribute this back. It'll likely be in the form of a new PR with the commits from @dgempiuc as the base.

rdifrango · 2023-12-18T15:54:44Z

Replaced by #220

rdifrango · 2024-01-17T14:33:21Z

@JonasKunz now that #220 is merged we should go ahead and close this one as it supersedes it.

added layout

5fca871

added layout

c887fcb

dgempiuc mentioned this pull request Sep 30, 2021

Adding Layout to logback-ecs-encoder #144

Closed

Merge remote-tracking branch 'upstream/main' into feature/144-layout-…

8bd3942

…ecs-encoder

eyalkoren reviewed Apr 27, 2022

View reviewed changes

felixbarny linked an issue Sep 9, 2022 that may be closed by this pull request

Adding Layout to logback-ecs-encoder #144

Closed

rdifrango mentioned this pull request Dec 15, 2023

Adding layout support to the logback ecs encoder #220

Merged

JonasKunz closed this Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added layout #145

added layout #145

dgempiuc commented Sep 30, 2021

cla-checker-service bot commented Sep 30, 2021 •

edited

Loading

apmmachine commented Sep 30, 2021 •

edited

Loading

Build stats

`Load a resource file from a library`

`Error signal`

fapena-galileo commented Dec 22, 2021

eyalkoren left a comment

eyalkoren Apr 27, 2022

eyalkoren Apr 27, 2022

eyalkoren Apr 27, 2022

eyalkoren Apr 27, 2022

felixbarny commented Apr 27, 2022

rdifrango commented Sep 7, 2022

felixbarny commented Sep 9, 2022

maxiking445 commented Apr 5, 2023

rdifrango commented Apr 18, 2023 •

edited

Loading

rdifrango commented Nov 29, 2023

rdifrango commented Dec 18, 2023

rdifrango commented Jan 17, 2024

	protected Layout<ILoggingEvent> layout;
	protected Layout<ILoggingEvent> messageLayout;

	EcsJsonSerializer.serializeFormattedMessage(builder, this.layout.doLayout(event));
	EcsJsonSerializer.serializeFormattedMessage(builder, this.messageLayout.doLayout(event));

	public Layout<ILoggingEvent> getLayout() {
	return this.layout;
	}

added layout #145

added layout #145

Conversation

dgempiuc commented Sep 30, 2021

cla-checker-service bot commented Sep 30, 2021 • edited Loading

apmmachine commented Sep 30, 2021 • edited Loading

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

fapena-galileo commented Dec 22, 2021

eyalkoren left a comment

Choose a reason for hiding this comment

eyalkoren Apr 27, 2022

Choose a reason for hiding this comment

eyalkoren Apr 27, 2022

Choose a reason for hiding this comment

eyalkoren Apr 27, 2022

Choose a reason for hiding this comment

eyalkoren Apr 27, 2022

Choose a reason for hiding this comment

felixbarny commented Apr 27, 2022

rdifrango commented Sep 7, 2022

felixbarny commented Sep 9, 2022

maxiking445 commented Apr 5, 2023

rdifrango commented Apr 18, 2023 • edited Loading

rdifrango commented Nov 29, 2023

rdifrango commented Dec 18, 2023

rdifrango commented Jan 17, 2024

cla-checker-service bot commented Sep 30, 2021 •

edited

Loading

apmmachine commented Sep 30, 2021 •

edited

Loading

`Load a resource file from a library`

`Error signal`

rdifrango commented Apr 18, 2023 •

edited

Loading