Adding layout support to the logback ecs encoder #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
agent-java
community
Closed
|
@felixbarny and @maxiking445 can you please take a look, as mentioned this replaces #145 but incorporates those changes into it. |
SylvainJuge
changed the title
SylvainJuge
previously approved these changes
Jan 9, 2024
logback-ecs-encoder/src/main/java/co/elastic/logging/logback/EcsEncoder.java
Outdated
Show resolved
Hide resolved
Fixed per the feedback from the public PR. Signed-off-by: Difrango, Ronald <Ronald.Difrango@fmr.com>
brianwarner
dismissed stale reviews from SylvainJuge and JonasKunz
via
da9c9fa
rdifrango
commented
Jan 16, 2024
| @@ -142,7 +142,7 @@ private void serializeMessage(ILoggingEvent event, StringBuilder builder) { | |||
| if (messageLayout == null) { | |||
| EcsJsonSerializer.serializeFormattedMessage(builder, event.getFormattedMessage()); | |||
| } else { | |||
| EcsJsonSerializer.serializeFormattedMessage(builder, this.messageLayout.doLayout(event)); | |||
| EcsJsonSerializer.serializeFormattedMessage(builder, messageLayout.doLayout(event)); | |||
There was a problem hiding this comment.
Resolved per the PR comments.
JonasKunz
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding layout support to the ecs encoder.
This is a replacement for #145 but incorporates the changes from that branch.